Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Remove as_derivative from SafeCallFilter#3006

Merged
bkchr merged 4 commits intomasterfrom
joe-as-derivative
Aug 16, 2023
Merged

Remove as_derivative from SafeCallFilter#3006
bkchr merged 4 commits intomasterfrom
joe-as-derivative

Conversation

@joepetrowski
Copy link
Copy Markdown
Contributor

@joepetrowski joepetrowski commented Aug 14, 2023

No description provided.

@joepetrowski joepetrowski added B0-silent Changes should not be mentioned in any release notes A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. T1-runtime This PR/Issue is related to the topic “runtime”. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Aug 14, 2023
@paritytech-ci paritytech-ci requested a review from a team August 14, 2023 15:02
@joepetrowski
Copy link
Copy Markdown
Contributor Author

joepetrowski commented Aug 14, 2023

bot rebase

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented Aug 14, 2023

Rebased

@xlc
Copy link
Copy Markdown
Contributor

xlc commented Aug 15, 2023

any explanations?

@joepetrowski
Copy link
Copy Markdown
Contributor Author

joepetrowski commented Aug 15, 2023

any explanations?

It should never have been there:

/// Calls that are allowed through this filter must:
...
/// 2. Cannot lead to another call being made;

@xlc
Copy link
Copy Markdown
Contributor

xlc commented Aug 15, 2023 •
edited
Loading

I still don't understand how the rule is being made

paritytech/polkadot#7080 (comment)

@joepetrowski
Copy link
Copy Markdown
Contributor Author

joepetrowski commented Aug 15, 2023

Do you use this on parachains or only the Relay?

@xlc
Copy link
Copy Markdown
Contributor

xlc commented Aug 15, 2023

this doesn’t impact us currently it is just me unsure about the rules

@bkchr bkchr merged commit 09aea7e into master Aug 16, 2023
@bkchr bkchr deleted the joe-as-derivative branch August 16, 2023 09:15
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@gilescope gilescope gilescope approved these changes

@KiChjang KiChjang KiChjang approved these changes

@bkchr bkchr bkchr approved these changes

@lexnv lexnv lexnv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@joepetrowski @xlc @gilescope @KiChjang @bkchr @lexnv