This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Companion for polkadot#7234 (XCM: Tools for uniquely referencing messages)#2601
Merged
Companion for polkadot#7234 (XCM: Tools for uniquely referencing messages)#2601
Conversation
11 tasks
bkontur
approved these changes
May 23, 2023
Contributor
|
@gavofyork could this be fixed now with this new message_id/topic stuff? wdyt? |
Member
Author
These changes don't much help this. In fact, the functions inside |
bkchr
approved these changes
May 25, 2023
ordian
approved these changes
May 25, 2023
ordian
left a comment
There was a problem hiding this comment.
approval stamp to unblock the companion check
sam0x17
approved these changes
May 25, 2023
This was referenced Jul 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to fix for new API. Also moves
DenyThenTryandDenyReserveTransferToRelayChaininto Polkadot.This revamps some of the *MPQ events to correctly report both the message hash and ID. It also moves the *MPQ code over to use
ExecuteXcm::prepare_and_executerather than the older APIs, which required simplifying some tests since the new API is at a slightly lower level.