Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

[Fix] Re-work UMP tests to execute a safe call#2566

Closed
ruseinov wants to merge 3 commits intoparitytech:ru/feature/xcm-emulatorfrom
ruseinov:ru/feature/xcm-emulator
Closed

[Fix] Re-work UMP tests to execute a safe call#2566
ruseinov wants to merge 3 commits intoparitytech:ru/feature/xcm-emulatorfrom
ruseinov:ru/feature/xcm-emulator

Conversation

@ruseinov
Copy link
Copy Markdown
Contributor

@ruseinov ruseinov commented May 11, 2023

No description provided.

@ruseinov ruseinov mentioned this pull request May 11, 2023
Merged
@pepoviola
Copy link
Copy Markdown
Contributor

pepoviola commented May 11, 2023

Hi @ruseinov, the zombienet test are failing because is using an old version. I can create a pr in the base branch or you can set the version to v1.3.52.

@ruseinov
Copy link
Copy Markdown
Contributor Author

ruseinov commented May 12, 2023

@pepoviola AFAIK the Zombienet tests are not required for merges, though I can bump the version

@ruseinov ruseinov requested a review from a team as a code owner May 14, 2023 13:34
@NachoPal
Copy link
Copy Markdown
Contributor

NachoPal commented May 17, 2023

@ruseinov We decided that examples does not make sense anymore since xcm-emulator will live in Cumulus and System Parachain tests are good examples.

Closing this in favor of #2576

@NachoPal NachoPal closed this May 17, 2023
@ruseinov
Copy link
Copy Markdown
Contributor Author

ruseinov commented May 17, 2023

Makes sense, I had the same idea initially.

@ruseinov ruseinov deleted the ru/feature/xcm-emulator branch May 17, 2023 18:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ruseinov @pepoviola @NachoPal