Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Companion: Rename BalanceConversion trait#2408

Closed
wischli wants to merge 3 commits intoparitytech:masterfrom
wischli:refactor/balance-conversion
Closed

Companion: Rename BalanceConversion trait#2408
wischli wants to merge 3 commits intoparitytech:masterfrom
wischli:refactor/balance-conversion

Conversation

@wischli
Copy link
Copy Markdown
Contributor

@wischli wischli commented Mar 30, 2023 •
edited
Loading

@wischli wischli mentioned this pull request Mar 30, 2023
Merged
@paritytech-cicd-pr
Copy link
Copy Markdown

paritytech-cicd-pr commented Mar 30, 2023

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2619872

@wischli
Copy link
Copy Markdown
Contributor Author

wischli commented Apr 3, 2023

Could you also give this a review @muharem @tonyalaribe?

@paritytech-ci paritytech-ci requested review from a team April 3, 2023 15:47
@joepetrowski joepetrowski added B0-silent Changes should not be mentioned in any release notes A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. T1-runtime This PR/Issue is related to the topic “runtime”. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Apr 4, 2023
@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented Apr 4, 2023

Waiting for commit status.

@paritytech-processbot
Copy link
Copy Markdown

paritytech-processbot bot commented Apr 4, 2023

Merge cancelled due to error. Error: Statuses failed for 1f25229

@bkchr
Copy link
Copy Markdown
Member

bkchr commented Apr 4, 2023

Merged into this pr: #2416

@bkchr bkchr closed this Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@bkchr bkchr bkchr approved these changes

@muharem muharem muharem approved these changes

@tonyalaribe tonyalaribe tonyalaribe approved these changes

@joepetrowski joepetrowski joepetrowski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T1-runtime This PR/Issue is related to the topic “runtime”.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@wischli @paritytech-cicd-pr @bkchr @muharem @tonyalaribe @joepetrowski