This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Increase recovery delay for pov-recovery#2143
Closed
skunert wants to merge 5 commits intoparitytech:masterfrom
Closed
Increase recovery delay for pov-recovery#2143skunert wants to merge 5 commits intoparitytech:masterfrom
skunert wants to merge 5 commits intoparitytech:masterfrom
Conversation
skunert
added
B0-silent
bkchr
approved these changes
Jan 25, 2023
Co-authored-by: Bastian Köcher <git@kchr.de>
davxy
approved these changes
Jan 25, 2023
michalkucharczyk
approved these changes
Jan 27, 2023
Contributor
Author
|
Please no merging on this yet, ironically pov test fails consistently here. |
Contributor
Author
|
Closing in favor of #2164 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase the time window before recovering a block via pov-recovery. Should alleviate the test flakyness caused by #2142 before implementing a proper retry.
This usage here is fine since it only recovers included blocks, these should be available.
cumulus/client/consensus/common/src/parachain_consensus.rs
Lines 41 to 42 in 977da03