Statemint runtimes to accept sufficient assets as xcm fee payment#1278
Conversation
…t-runtimes-to-accept-sufficient-assets
girazoki
changed the title
girazoki
changed the title
We are working on a dir restructure that will include a folder for all asset parachain runtimes. I think we could probably add a |
hbulgarini
added
the
T7-system_parachains
|
Thanks for the PR @girazoki ! could you please fix the conflicting files? as Joe mentioned the dir restructure might originates the conflicts described. |
|
sure! |
…t-runtimes-to-accept-sufficient-assets
| ExtBuilder { balances: vec![], collators: vec![] } | ||
| } | ||
| } | ||
| use frame_support::traits::GenesisBuild; |
There was a problem hiding this comment.
can't these builders be reused?
There was a problem hiding this comment.
I can put the builder in common so that all runtimes can access it yes
There was a problem hiding this comment.
Moved the builders to asset-test-utils package, now they are shared across all statemine runtimes
…s-to-accept-sufficient-assets
…t-runtimes-to-accept-sufficient-assets
…' of https://github.com/girazoki/cumulus into girazoki-statemint-runtimes-to-accept-sufficient-assets
…t-runtimes-to-accept-sufficient-assets
|
bot merge |
8 participants
Solves #1247
It adds a new trader
TakeFirstAssetTrader, which takes the first asset and tries to charge xcm execution on such asset. If such asset in a sufficient asset inpallet-assets, then thefee(corresponding to how much it would cost in the native token) is converted to anasset_fee(corresponding to how much it would cost in the specified asset) based on the difference on the existential deposits.Charged fee is for now given to the block author. I am open to suggestions on this
Missing tests, I am unsure where to add these tests. Open to suggestions on this too