Companion for Substrate#11062

[koute]

Companion for paritytech/substrate#11062

[wigy-opensource-developer]

Seems like adding a new command-line argument goes quite far. Probably other projects building on our CLI are also affected, right?

[koute]

Seems like adding a new command-line argument goes quite far. Probably other projects building on our CLI are also affected, right?

Well, yeah. Although the trait for the CLI args sets the new argument to false so unless the Configuration struct is constructed manually somewhere (and here it is in tests) everything should still compile at least. (We should probably consider making the Configuration into a builder so that every time a new argument is added it wouldn't be necessary to also modify everything at the same time.)

[wigy-opensource-developer]

You have not introduced it, but all that copy-paste in polkadot-parachains/src/service.rs made me slightly dizzy. I am definitely looking forward to make it easier to define a concrete client for a chain with less code. Still, how nice that each of these copies are separate chains and you just need this much code to create them.

[koute]

Yeah, I definitely agree it'd be nice to refactor this eventually!

[paritytech-processbot]

Waiting for commit status.