Failed to instantiate contract ... Some("OutOfGas")

[mutantcornholio]

• clone scc-testing repo
• cd axelar-gmp-sdk-solidity
• update environment to provide ETC_RPC_BIN, REVIVE_DEV_NODE_BIN and RESOLC_BIN
• run npx hardhat test --network hardhat --grep 'AxelarValuedExpressExecutableTest Execute With Token \(different ERC20\) pt.1

the output is:

  1) GMPE
       AxelarValuedExpressExecutableTest Execute With Token (different ERC20) pt.1
         Should Execute without express:
     ProviderError: Failed to instantiate contract: Module(ModuleError { index: 5, error: [3, 0, 0, 0], message: Some("OutOfGas") })
      at HttpProvider.request (/Users/cornholio/work/parity/scc-testing/axelar-gmp-sdk-solidity/node_modules/hardhat/src/internal/core/providers/http.ts:116:21)
      at processTicksAndRejections (node:internal/process/task_queues:105:5)
      at EthersProviderWrapper.send (/Users/cornholio/work/parity/scc-testing/axelar-gmp-sdk-solidity/node_modules/@nomiclabs/hardhat-ethers/src/internal/ethers-provider-wrapper.ts:13:20)

run the same, but with polkadot: false in config, and the test passes.

[marian-radu]

The initial issue seems to be fixed on master. The tests are passing for:
1. polkadot: false
2. polkadot { target: 'evm' }

The tests are failing for polkadot { target: 'pvm' } due to handleFactoryDependencies failing to upload child contracts. This issue seems to be unrelated to the tests from this ticket.

Tests output for polkadot { target: 'evm' }

  GMPE
    AxelarValuedExpressExecutableTest Execute With Token (different ERC20) pt.1
      ✔ Should Execute without express (57ms)
      ✔ Should not Execute without gateway approval
      ✔ Should Execute with express before approval (275ms)
      ✔ Should not Execute with express before approval without proper payment (45ms)
      ✔ Should not Execute with express after approval (57ms)
      ✔ Should not Execute with express after execution (57ms)

When polkadot { target: 'pvm' } is configured, the CreateDeploy.sol contract deployment fails with:

"error": "StackUnderflow", "value": "0x0", "type": "CREATE".

However, compiling the contract and deploying it using https://github.com/paritytech/contracts-boilerplate works fine.

[marian-radu]

After digging deeper into why the PVM bytecode tests are failing, I discovered the following:

1. PR Rework gas mapping polkadot-sdk#9803 introduced a change in pallet-revive that sets the origin to EthTransaction for ETH calls.
   Raw EVM transactions containing non-ETH revive calls (like in https://github.com/paritytech/hardhat-polkadot/blob/main/packages/hardhat-polkadot-node/src/core/factory-support.ts#L81) haven’t been updated to handle the EthTransaction origin.
2. The change that saves Ethereum transaction receipts in ETH blocks also does not cover EVM transactions that include non-ETH revive(e.g upload_code) calls.
3. PoC fixes can be found on branch: https://github.com/paritytech/polkadot-sdk/tree/180-failed-to-instantiate-contract-someoutofgas