Skip to content

Dynamic loading of pallets for cumulus + renaming statemine/statemint/westmint to asset-hub-kusama/polkadot/westend#34

Merged
bkontur merged 4 commits intomainfrom
bko-cumulus-pallets
Jun 20, 2023
Merged

Dynamic loading of pallets for cumulus + renaming statemine/statemint/westmint to asset-hub-kusama/polkadot/westend#34
bkontur merged 4 commits intomainfrom
bko-cumulus-pallets

Conversation

@bkontur
Copy link
Copy Markdown
Contributor

@bkontur bkontur commented Jun 15, 2023

…/westmint to asset-hub-kusama/polkadot/westend
@bkontur bkontur requested a review from a team as a code owner June 15, 2023 11:35
@bkontur
Copy link
Copy Markdown
Contributor Author

bkontur commented Jun 15, 2023

let me check if script is ok before merge - waiting for local run with (step=2, repeat=2)

@bkontur
Copy link
Copy Markdown
Contributor Author

bkontur commented Jun 15, 2023

@ggwpez @oleg-plakida
what is this script and PR paritytech/cumulus#2712 about? it is something new?

I just want to be sure, that if we merge this PR, then everything still works.

@joepetrowski @gilescope @chevdor
just in case, I am not sure how were the last weights regenerated for parachains-v9430-rc3 / parachains-v9430-rc4 / parachains-v9430-rc5, which script or job was used? I hope it does not colide with this PR and paritytech/cumulus#2712

@joepetrowski
Copy link
Copy Markdown

I think @EgorPopelyaev would know

@bkontur
Copy link
Copy Markdown
Contributor Author

bkontur commented Jun 16, 2023

@NachoPal
can you please check "Fix for glutton" commit: f5083a9 ?

@bkontur
Copy link
Copy Markdown
Contributor Author

bkontur commented Jun 16, 2023

I am investigation last thing, why does it not work for multiple pallet instances, like pallet_assets or pallet_bridge_grandpa:
(I see now)

Error: Input("Multiple results were written to the same file. This can happen when there are multiple instances of a pallet deployed and `--output` forces the output of all instances into the same file. Use `--unsafe-overwrite-results` to ignore this error. The affected files are: [\"./parachains/runtimes/assets/asset-hub-kusama/src/weights/pallet_assets.rs\"]")


Error: Input("Multiple results were written to the same file. This can happen when there are multiple instances of a pallet deployed and `--output` forces the output of all instances into the same file. Use `--unsafe-overwrite-results` to ignore this error. The affected files are: [\"./parachains/runtimes/bridge-hubs/bridge-hub-rococo/src/weights/pallet_bridge_grandpa.rs\"]")

but in Cumulus bench bot works:
paritytech/cumulus#2743
paritytech/cumulus@3b9259e

Copy link
Copy Markdown
Collaborator

@mordamax mordamax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unapproving for now until final fixes applied

@bkontur
Copy link
Copy Markdown
Contributor Author

bkontur commented Jun 16, 2023

@mordamax
ok, for Cumulus, now it is working as expected, dynamic loading of all pallets and works for multiple instances + xcm hack

Copy link
Copy Markdown
Collaborator

@mordamax mordamax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@bkontur bkontur merged commit f22b1d4 into main Jun 20, 2023
@bkontur bkontur deleted the bko-cumulus-pallets branch June 20, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants