Do not strip out panic messages in debug builds#326
Merged
Conversation
cmichi
approved these changes
Aug 12, 2021
Contributor
Author
|
Building that test in release mode now. That should fix it. |
cmichi
approved these changes
Aug 12, 2021
cmichi
left a comment
cmichi
left a comment
Collaborator
There was a problem hiding this comment.
I'll do a release soonish.
HCastano
pushed a commit
that referenced
this pull request
Aug 12, 2021
* Add log output * Add #326 to changelog * Bump version * Fix changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should keep the panic messages for debug builds because they convey valuable information. Until
Resultbased error handling is implemented that is even the only way of reacting to runtime errors (as opposed to programming errors for which panics are usually used).