fix: dryRun requires xcmVersion, so use safeXcmVersion if none given by andrew-ifrita · Pull Request #571 · paritytech/asset-transfer-api

andrew-ifrita · 2025-06-02T10:34:57Z

dryRun calls require an xcmVersion. Default to safeXcm version if none is given.

Relates to this comment in polkadot-sdk.

Also fixes the test issue mentioned in these PRs:

Bumps [typedoc](https://github.com/TypeStrong/TypeDoc) from 0.28.4 to 0.28.5. - [Release notes](https://github.com/TypeStrong/TypeDoc/releases) - [Changelog](https://github.com/TypeStrong/typedoc/blob/master/CHANGELOG.md) - [Commits](TypeStrong/typedoc@v0.28.4...v0.28.5) --- updated-dependencies: - dependency-name: typedoc dependency-version: 0.28.5 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

TarikGul

Looks good to me, thanks 🚀

andrew-ifrita · 2025-06-02T12:26:22Z

The 4 e2e tests are also currently failing in main which suggest flaky or unstable tests. Logs from main below. I will use discretion and merge this and then investigate and fix the testing issue.

 ❯  e2e  e2e-tests/moonbeam.hydration.spec.ts (4 tests | 2 failed) 189093ms
   ✓ Moonbeam <> Hydration > XCM V3 > Transfer GLMR from Moonbeam to Hydration  50461ms
   × Moonbeam <> Hydration > XCM V3 > Transfer HDX from Hydration to Moonbeam 48559ms
     → Snapshot `Moonbeam <> Hydration > XCM V3 > Transfer HDX from Hydration to Moonbeam > moonbeam recipients updated hdx balance 1` mismatched
   ✓ Moonbeam <> Hydration > XCM V4 > Transfer GLMR from Moonbeam to Hydration  39532ms
   × Moonbeam <> Hydration > XCM V4 > Transfer HDX from Hydration to Moonbeam 50540ms
     → Snapshot `Moonbeam <> Hydration > XCM V4 > Transfer HDX from Hydration to Moonbeam > moonbeam recipients updated hdx balance 1` mismatched

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Failed Tests 2 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯

 FAIL   e2e  e2e-tests/moonbeam.hydration.spec.ts > Moonbeam <> Hydration > XCM V3 > Transfer HDX from Hydration to Moonbeam
Error: Snapshot `Moonbeam <> Hydration > XCM V3 > Transfer HDX from Hydration to Moonbeam > moonbeam recipients updated hdx balance 1` mismatched

- Expected
+ Received

  {
-   "balance": "(rounded 10000000000000000)",
+   "balance": 0,
    "extra": null,
    "reason": {
-     "sufficient": null,
+     "consumer": null,
    },
    "status": "Liquid",
  }

 ❯ Checker.toMatchSnapshot node_modules/@acala-network/chopsticks-testing/dist/esm/check.js:207:51
 ❯ e2e-tests/moonbeam.hydration.spec.ts:141:4
    139|    ).unwrapOrDefault();
    140| 
    141|    await check(recipientUpdatedHDXBalance)
       |    ^
    142|     .redact({ number: 1 })
    143|     .toMatchSnapshot('moonbeam recipients updated hdx balance');

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/2]⎯

 FAIL   e2e  e2e-tests/moonbeam.hydration.spec.ts > Moonbeam <> Hydration > XCM V4 > Transfer HDX from Hydration to Moonbeam
Error: Snapshot `Moonbeam <> Hydration > XCM V4 > Transfer HDX from Hydration to Moonbeam > moonbeam recipients updated hdx balance 1` mismatched

- Expected
+ Received

  {
-   "balance": "(rounded 10000000000000000)",
+   "balance": 0,
    "extra": null,
    "reason": {
-     "sufficient": null,
+     "consumer": null,
    },
    "status": "Liquid",
  }

 ❯ Checker.toMatchSnapshot node_modules/@acala-network/chopsticks-testing/dist/esm/check.js:207:51
 ❯ e2e-tests/moonbeam.hydration.spec.ts:242:4
    240|    ).unwrapOrDefault();
    241| 
    242|    await check(recipientUpdatedHDXBalance)
       |    ^
    243|     .redact({ number: 1 })
    244|     .toMatchSnapshot('moonbeam recipients updated hdx balance');

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[2/2]⎯


  Snapshots  2 failed
 Test Files  1 failed (1)
      Tests  2 failed | 2 passed (4)
   Start at  14:19:27
   Duration  190.86s (transform 608ms, setup 9ms, collect 1.51s, tests 189.09s, environment 0ms, prepare 55ms)

❯  e2e  e2e-tests/moonbeam.ethereum.spec.ts (2 tests | 2 failed) 49780ms
   × Moonbeam <> Ethereum > XCM V3 > Transfer Snowbridge WETH from Moonbeam to Ethereum 34537ms
     → Snapshot `Moonbeam <> Ethereum > XCM V3 > Transfer Snowbridge WETH from Moonbeam to Ethereum > Moonbeam xcm message sent 1` mismatched
   × Moonbeam <> Ethereum > XCM V4 > Transfer Snowbridge WETH from Moonbeam to Ethereum 15241ms
     → Snapshot `Moonbeam <> Ethereum > XCM V4 > Transfer Snowbridge WETH from Moonbeam to Ethereum > Moonbeam xcm message sent 1` mismatched

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Failed Tests 2 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯

 FAIL   e2e  e2e-tests/moonbeam.ethereum.spec.ts > Moonbeam <> Ethereum > XCM V3 > Transfer Snowbridge WETH from Moonbeam to Ethereum
Error: Snapshot `Moonbeam <> Ethereum > XCM V3 > Transfer Snowbridge WETH from Moonbeam to Ethereum > Moonbeam xcm message sent 1` mismatched

- Expected
+ Received

- [
-   {
-     "data": {
-       "outcome": {
-         "Complete": {
-           "used": {
-             "proofSize": "(redacted)",
-             "refTime": "(redacted)",
-           },
-         },
-       },
-     },
-     "method": "Attempted",
-     "section": "polkadotXcm",
-   },
-   {
-     "data": {
-       "fees": [],
-       "paying": {
-         "interior": {
-           "X1": [
-             {
-               "AccountKey20": {
-                 "key": "0xf24ff3a9cf04c71dbc94d0b566f7a27b94566cac",
-                 "network": "Polkadot",
-               },
-             },
-           ],
-         },
-         "parents": 0,
-       },
-     },
-     "method": "FeesPaid",
-     "section": "polkadotXcm",
-   },
-   {
-     "data": {
-       "destination": {
-         "interior": {
-           "X1": [
-             {
-               "Parachain": 1000,
-             },
-           ],
-         },
-         "parents": 1,
-       },
-       "message": [
-         {
-           "WithdrawAsset": [
-             {
-               "fun": {
-                 "Fungible": 100000000000,
-               },
-               "id": {
-                 "interior": "Here",
-                 "parents": 1,
-               },
-             },
-             {
-               "fun": {
-                 "Fungible": 750000000000000,
-               },
-               "id": {
-                 "interior": {
-                   "X2": [
-                     {
-                       "GlobalConsensus": {
-                         "Ethereum": {
-                           "chainId": 1,
-                         },
-                       },
-                     },
-                     {
-                       "AccountKey20": {
-                         "key": "0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2",
-                         "network": null,
-                       },
-                     },
-                   ],
-                 },
-                 "parents": 2,
-               },
-             },
-           ],
-         },
-         "ClearOrigin",
-         {
-           "BuyExecution": {
-             "fees": {
-               "fun": {
-                 "Fungible": 100000000000,
-               },
-               "id": {
-                 "interior": "Here",
-                 "parents": 1,
-               },
-             },
-             "weightLimit": "Unlimited",
-           },
-         },
-         {
-           "SetAppendix": [
-             {
-               "DepositAsset": {
-                 "assets": {
-                   "Wild": "All",
-                 },
-                 "beneficiary": {
-                   "interior": {
-                     "X1": [
-                       {
-                         "AccountId32": {
-                           "id": "(hash)",
-                           "network": null,
-                         },
-                       },
-                     ],
-                   },
-                   "parents": 0,
-                 },
-               },
-             },
-           ],
-         },
-         {
-           "InitiateReserveWithdraw": {
-             "assets": {
-               "Wild": {
-                 "AllOf": {
-                   "fun": "Fungible",
-                   "id": {
-                     "interior": {
-                       "X2": [
-                         {
-                           "GlobalConsensus": {
-                             "Ethereum": {
-                               "chainId": 1,
-                             },
-                           },
-                         },
-                         {
-                           "AccountKey20": {
-                             "key": "0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2",
-                             "network": null,
-                           },
-                         },
-                       ],
-                     },
-                     "parents": 2,
-                   },
-                 },
-               },
-             },
-             "reserve": {
-               "interior": {
-                 "X1": [
-                   {
-                     "GlobalConsensus": {
-                       "Ethereum": {
-                         "chainId": 1,
-                       },
-                     },
-                   },
-                 ],
-               },
-               "parents": 2,
-             },
-             "xcm": [
-               {
-                 "BuyExecution": {
-                   "fees": {
-                     "fun": {
-                       "Fungible": 1,
-                     },
-                     "id": {
-                       "interior": {
-                         "X1": [
-                           {
-                             "AccountKey20": {
-                               "key": "0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2",
-                               "network": null,
-                             },
-                           },
-                         ],
-                       },
-                       "parents": 0,
-                     },
-                   },
-                   "weightLimit": "Unlimited",
-                 },
-               },
-               {
-                 "DepositAsset": {
-                   "assets": {
-                     "Wild": {
-                       "AllCounted": 1,
-                     },
-                   },
-                   "beneficiary": {
-                     "interior": {
-                       "X1": [
-                         {
-                           "AccountKey20": {
-                             "key": "0xf24ff3a9cf04c71dbc94d0b566f7a27b94566cac",
-                             "network": null,
-                           },
-                         },
-                       ],
-                     },
-                     "parents": 0,
-                   },
-                 },
-               },
-               {
-                 "SetTopic": 0,
-               },
-             ],
-           },
-         },
-         {
-           "SetTopic": 0,
-         },
-       ],
-       "messageId": "(redacted)",
-       "origin": {
-         "interior": {
-           "X1": [
-             {
-               "AccountKey20": {
-                 "key": "0xf24ff3a9cf04c71dbc94d0b566f7a27b94566cac",
-                 "network": "Polkadot",
-               },
-             },
-           ],
-         },
-         "parents": 0,
-       },
-     },
-     "method": "Sent",
-     "section": "polkadotXcm",
-   },
- ]
+ []

 ❯ Checker.toMatchSnapshot node_modules/@acala-network/chopsticks-testing/dist/esm/check.js:207:51
 ❯ e2e-tests/moonbeam.ethereum.spec.ts:117:4
    115|    await moonbeam.dev.newBlock();
    116| 
    117|    await checkSystemEvents(moonbeam, 'polkadotXcm')
       |    ^
    118|     .redact({ redactKeys: new RegExp('messageId|proofSize|refTime') })
    119|     .toMatchSnapshot('Moonbeam xcm message sent');

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/2]⎯

 FAIL   e2e  e2e-tests/moonbeam.ethereum.spec.ts > Moonbeam <> Ethereum > XCM V4 > Transfer Snowbridge WETH from Moonbeam to Ethereum
Error: Snapshot `Moonbeam <> Ethereum > XCM V4 > Transfer Snowbridge WETH from Moonbeam to Ethereum > Moonbeam xcm message sent 1` mismatched

- Expected
+ Received

- [
-   {
-     "data": {
-       "outcome": {
-         "Complete": {
-           "used": {
-             "proofSize": "(redacted)",
-             "refTime": "(redacted)",
-           },
-         },
-       },
-     },
-     "method": "Attempted",
-     "section": "polkadotXcm",
-   },
-   {
-     "data": {
-       "fees": [],
-       "paying": {
-         "interior": {
-           "X1": [
-             {
-               "AccountKey20": {
-                 "key": "0xf24ff3a9cf04c71dbc94d0b566f7a27b94566cac",
-                 "network": "Polkadot",
-               },
-             },
-           ],
-         },
-         "parents": 0,
-       },
-     },
-     "method": "FeesPaid",
-     "section": "polkadotXcm",
-   },
-   {
-     "data": {
-       "destination": {
-         "interior": {
-           "X1": [
-             {
-               "Parachain": 1000,
-             },
-           ],
-         },
-         "parents": 1,
-       },
-       "message": [
-         {
-           "WithdrawAsset": [
-             {
-               "fun": {
-                 "Fungible": 100000000000,
-               },
-               "id": {
-                 "interior": "Here",
-                 "parents": 1,
-               },
-             },
-             {
-               "fun": {
-                 "Fungible": 750000000000000,
-               },
-               "id": {
-                 "interior": {
-                   "X2": [
-                     {
-                       "GlobalConsensus": {
-                         "Ethereum": {
-                           "chainId": 1,
-                         },
-                       },
-                     },
-                     {
-                       "AccountKey20": {
-                         "key": "0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2",
-                         "network": null,
-                       },
-                     },
-                   ],
-                 },
-                 "parents": 2,
-               },
-             },
-           ],
-         },
-         "ClearOrigin",
-         {
-           "BuyExecution": {
-             "fees": {
-               "fun": {
-                 "Fungible": 100000000000,
-               },
-               "id": {
-                 "interior": "Here",
-                 "parents": 1,
-               },
-             },
-             "weightLimit": "Unlimited",
-           },
-         },
-         {
-           "SetAppendix": [
-             {
-               "DepositAsset": {
-                 "assets": {
-                   "Wild": "All",
-                 },
-                 "beneficiary": {
-                   "interior": {
-                     "X1": [
-                       {
-                         "AccountId32": {
-                           "id": "(hash)",
-                           "network": null,
-                         },
-                       },
-                     ],
-                   },
-                   "parents": 0,
-                 },
-               },
-             },
-           ],
-         },
-         {
-           "InitiateReserveWithdraw": {
-             "assets": {
-               "Wild": {
-                 "AllOf": {
-                   "fun": "Fungible",
-                   "id": {
-                     "interior": {
-                       "X2": [
-                         {
-                           "GlobalConsensus": {
-                             "Ethereum": {
-                               "chainId": 1,
-                             },
-                           },
-                         },
-                         {
-                           "AccountKey20": {
-                             "key": "0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2",
-                             "network": null,
-                           },
-                         },
-                       ],
-                     },
-                     "parents": 2,
-                   },
-                 },
-               },
-             },
-             "reserve": {
-               "interior": {
-                 "X1": [
-                   {
-                     "GlobalConsensus": {
-                       "Ethereum": {
-                         "chainId": 1,
-                       },
-                     },
-                   },
-                 ],
-               },
-               "parents": 2,
-             },
-             "xcm": [
-               {
-                 "BuyExecution": {
-                   "fees": {
-                     "fun": {
-                       "Fungible": 1,
-                     },
-                     "id": {
-                       "interior": {
-                         "X1": [
-                           {
-                             "AccountKey20": {
-                               "key": "0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2",
-                               "network": null,
-                             },
-                           },
-                         ],
-                       },
-                       "parents": 0,
-                     },
-                   },
-                   "weightLimit": "Unlimited",
-                 },
-               },
-               {
-                 "DepositAsset": {
-                   "assets": {
-                     "Wild": {
-                       "AllCounted": 1,
-                     },
-                   },
-                   "beneficiary": {
-                     "interior": {
-                       "X1": [
-                         {
-                           "AccountKey20": {
-                             "key": "0xf24ff3a9cf04c71dbc94d0b566f7a27b94566cac",
-                             "network": null,
-                           },
-                         },
-                       ],
-                     },
-                     "parents": 0,
-                   },
-                 },
-               },
-               {
-                 "SetTopic": 0,
-               },
-             ],
-           },
-         },
-         {
-           "SetTopic": 0,
-         },
-       ],
-       "messageId": "(redacted)",
-       "origin": {
-         "interior": {
-           "X1": [
-             {
-               "AccountKey20": {
-                 "key": "0xf24ff3a9cf04c71dbc94d0b566f7a27b94566cac",
-                 "network": "Polkadot",
-               },
-             },
-           ],
-         },
-         "parents": 0,
-       },
-     },
-     "method": "Sent",
-     "section": "polkadotXcm",
-   },
- ]
+ []

 ❯ Checker.toMatchSnapshot node_modules/@acala-network/chopsticks-testing/dist/esm/check.js:207:51
 ❯ e2e-tests/moonbeam.ethereum.spec.ts:201:4
    199|    await moonbeam.dev.newBlock();
    200| 
    201|    await checkSystemEvents(moonbeam, 'polkadotXcm')
       |    ^
    202|     .redact({ redactKeys: new RegExp('messageId|proofSize|refTime') })
    203|     .toMatchSnapshot('Moonbeam xcm message sent');

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[2/2]⎯


  Snapshots  2 failed
             6 obsolete
             ↳ e2e-tests/moonbeam.ethereum.spec.ts
               · Moonbeam <> Ethereum > XCM V3 > Transfer Snowbridge WETH from Moonbeam to Ethereum > assetHub xcmp message sent 1
               · Moonbeam <> Ethereum > XCM V3 > Transfer Snowbridge WETH from Moonbeam to Ethereum > assethub foreign assets burned 1
               · Moonbeam <> Ethereum > XCM V3 > Transfer Snowbridge WETH from Moonbeam to Ethereum > bridgehub ethereum outbound queue events 1
               · Moonbeam <> Ethereum > XCM V4 > Transfer Snowbridge WETH from Moonbeam to Ethereum > assetHub xcmp message sent 1
               · Moonbeam <> Ethereum > XCM V4 > Transfer Snowbridge WETH from Moonbeam to Ethereum > assethub foreign assets burned 1
               · Moonbeam <> Ethereum > XCM V4 > Transfer Snowbridge WETH from Moonbeam to Ethereum > bridgehub ethereum outbound queue events 1

 Test Files  1 failed (1)
      Tests  2 failed (2)
   Start at  14:16:57
   Duration  51.48s (transform 566ms, setup 9ms, collect 1.45s, tests 49.78s, environment 0ms, prepare 50ms)

andrew-ifrita force-pushed the fix/dry-run-arg-when-no-xcm-version branch from 688244f to f50558e Compare June 2, 2025 10:35

fix: dryRun requires xcmVersion, so use safeXcmVersion if none given

93ff45b

andrew-ifrita changed the title ~~Fix: dryRun should always be given an explicit xcmVersion~~ fix: dryRun should always be given an explicit xcmVersion Jun 2, 2025

andrew-ifrita changed the title ~~fix: dryRun should always be given an explicit xcmVersion~~ fix: dryRun requires xcmVersion, so use safeXcmVersion if none given Jun 2, 2025

test: Fix tests that returned a null xcmVersion

1a03208

andrew-ifrita force-pushed the fix/dry-run-arg-when-no-xcm-version branch from f50558e to 1a03208 Compare June 2, 2025 10:52

andrew-ifrita requested review from TarikGul and seadanda June 2, 2025 10:55

test: fix test where it expects x1 to be an array

7e71e84

TarikGul approved these changes Jun 2, 2025

View reviewed changes

andrew-ifrita removed the request for review from seadanda June 2, 2025 11:50

andrew-ifrita merged commit 962cfb1 into main Jun 2, 2025
7 of 8 checks passed

andrew-ifrita deleted the fix/dry-run-arg-when-no-xcm-version branch June 2, 2025 12:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: dryRun requires xcmVersion, so use safeXcmVersion if none given#571

fix: dryRun requires xcmVersion, so use safeXcmVersion if none given#571
andrew-ifrita merged 4 commits into
mainfrom
fix/dry-run-arg-when-no-xcm-version

andrew-ifrita commented Jun 2, 2025 •

edited

Loading

Uh oh!

TarikGul left a comment

Uh oh!

andrew-ifrita commented Jun 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

andrew-ifrita commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TarikGul left a comment

Choose a reason for hiding this comment

Uh oh!

andrew-ifrita commented Jun 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

andrew-ifrita commented Jun 2, 2025 •

edited

Loading