Skip to content

fix: add support for xcmv4 types#372

Merged
marshacb merged 9 commits intomainfrom
cameron-support-xcmv4-types
Feb 26, 2024
Merged

fix: add support for xcmv4 types#372
marshacb merged 9 commits intomainfrom
cameron-support-xcmv4-types

Conversation

@marshacb
Copy link
Copy Markdown
Contributor

@marshacb marshacb commented Feb 21, 2024 •
edited
Loading

Description

This PR adds support for relevant type changes that were introduced in XCMv4.

Changes

  • Added v4 as a supported XCM version
  • Added XCMv4 Asset type which no longer specifies Concrete as part of the AssetId
  • Updated Destination/Beneficiary type construction to reflect new array junction syntax
  • Added Westend -> AssetHub, AssetHub -> Westend and Asset Hub -> Collectives Xcmv4 examples
  • Updated relevant type construction in createXcmTypes
  • Added V4 test cases for each direction in createXcmTypes
  • Removed Multi from sortMultiAssetsAscending and dedupeMultiAssets

closes: #370

@marshacb marshacb changed the title fix: add support for xcmv4 types[WIP] fix: add support for xcmv4 types [WIP] Feb 21, 2024
@IkerAlus
Copy link
Copy Markdown
Contributor

IkerAlus commented Feb 22, 2024

can we add a bit context here to help reviewers, also link to the issue this is supposed to close?

@marshacb
update xcmv4 dest and beneficiary types
eba5385 
add westend to assethub example
@marshacb
added westend assethub to westend xcmv4 example
b5ec959
@marshacb
update XcmV4DestBeneficiary to reflect v4 array junction changes
1166f3b 
added Westend Asset Hub to Westend Collectives example
fixed beneficiary naming
@marshacb marshacb changed the title fix: add support for xcmv4 types [WIP] fix: add support for xcmv4 types Feb 23, 2024
@marshacb marshacb requested review from TarikGul and bee344 February 23, 2024 14:13
TarikGul
TarikGul reviewed Feb 23, 2024
View reviewed changes
TarikGul
TarikGul approved these changes Feb 23, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing Job LGTM, just 1 small nit

@marshacb marshacb merged commit 0e5c545 into main Feb 26, 2024
@Polkadot-Forum
Copy link
Copy Markdown

Polkadot-Forum commented Mar 8, 2024

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/parity-tech-update-for-february/6630/1

@andrew-ifrita andrew-ifrita deleted the cameron-support-xcmv4-types branch May 20, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TarikGul TarikGul TarikGul approved these changes

@bee344 bee344 Awaiting requested review from bee344

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support XCM v4 new types

4 participants

@marshacb @IkerAlus @Polkadot-Forum @TarikGul