Fix Node custom labels for v26 nightly; add test for nightly #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors node_test.go to add a new "nightly" test, that gets the latest nightly build of Node, runs a docker container, and then runs the test as normal. While creating this, I also discovered a real issue in our support for the v26 prerelease (slated for release in April): nodejs/node#56290 causes one of the symbols we rely on to no longer be exported, so we need to grab it a different way. This commit also fixes that issue.
Collaborator
Author
|
Note: the test might be flaky until open-telemetry#877 lands. |
gnurizen
approved these changes
Oct 22, 2025
Collaborator
|
Some lint issue but otherwise looks good! |
gnurizen
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors node_test.go to add a new "nightly" test, that gets the latest nightly build of Node, runs a docker container, and then runs the test as normal.
While creating this, I also discovered a real issue in our support for the v26 prerelease (slated for release in April):
nodejs/node#56290 causes one of the symbols we rely on to no longer be exported, so we need to grab it a different way. This commit also fixes that issue.