Fixes to types#3302
Merged
HackbrettXXX merged 5 commits intoparallax:masterfrom Oct 28, 2021
KurtGokhan:typescript-fixes
Merged
Fixes to types#3302HackbrettXXX merged 5 commits intoparallax:masterfrom KurtGokhan:typescript-fixes
HackbrettXXX merged 5 commits intoparallax:masterfrom
KurtGokhan:typescript-fixes
Conversation
HackbrettXXX
requested changes
Oct 27, 2021
Collaborator
HackbrettXXX
left a comment
HackbrettXXX
left a comment
There was a problem hiding this comment.
Thanks. Looks good. Could you also add format to the ImageOptions type?
Contributor
Author
|
@HackbrettXXX I think it is https://github.com/parallax/jsPDF/blob/master/src/modules/addimage.js#L1020 |
Contributor
Author
|
Ah, sorry. I will add it to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a problem I had when I tried to use
htmlAPI manually in Typescript. Since it is wrapped inPromise, Typescript will unwrap it all the way down and resolve the awaited type toany. It should have beenHTMLWorkersince it already extendsPromise. Also added some useful methods toHTMLWorkertype.Also fixes #3238