Merged
Conversation
jspdf.plugin.addimage.js
Outdated
Contributor
There was a problem hiding this comment.
I think it should be good checking element.nodeName === 'IMG' before getAttribute()
Contributor
There was a problem hiding this comment.
Also, getAttribute can return null, so using indexOf on it will throw.
Contributor
|
Thanks, i'm merging without testing (since i don't think it's needed) |
diegocr
added a commit
that referenced
this pull request
May 25, 2014
Contributor
|
I just did a few minor changes on fac3703 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support of![]()
elements with dataurl src