feat: basic lsp #401
Draft
feat: basic lsp #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
commented
Aug 15, 2025
onbjerg
added
C-enhancement
Contributor
Author
|
Going to migrate to |
onbjerg
force-pushed
the
onbjerg/lsp-scaffolding
branch
11 times, most recently
from
5b46d64 to
dbe18cf
Compare
DaniPopes
reviewed
Aug 16, 2025
onbjerg
force-pushed
the
onbjerg/lsp-scaffolding
branch
6 times, most recently
from
4cad319 to
6b47d04
Compare
onbjerg
force-pushed
the
onbjerg/lsp-scaffolding
branch
4 times, most recently
from
b361c90 to
5e87c38
Compare
DaniPopes
reviewed
Aug 18, 2025
| .notification::<notif::Exit>(|_, _| ControlFlow::Break(Ok(()))); | ||
|
|
||
| // Notifications | ||
| router |
Member
There was a problem hiding this comment.
why don't we implement the LanguageServer trait?
onbjerg
force-pushed
the
onbjerg/lsp-scaffolding
branch
from
5e87c38 to
f2a35c1
Compare
onbjerg
force-pushed
the
onbjerg/lsp-scaffolding
branch
8 times, most recently
from
3c5c3f6 to
e89085e
Compare
|
getting ICE compiler errors from the incremental document sync while using current solar lsp. |
Contributor
Author
|
Hi @mmsaki, it's currently a draft and not entirely complete, so it's expected to not work in all cases. Can you share what project you tried using it in for future reference? I'll make sure it works before merging |
onbjerg
force-pushed
the
onbjerg/lsp-scaffolding
branch
4 times, most recently
from
0efd93e to
63ae5f5
Compare
onbjerg
force-pushed
the
onbjerg/lsp-scaffolding
branch
from
63ae5f5 to
55f30f8
Compare
onbjerg
force-pushed
the
onbjerg/lsp-scaffolding
branch
2 times, most recently
from
44ccde5 to
51051d1
Compare
DaniPopes
added a commit
that referenced
this pull request
Sep 15, 2025
Allow the tracing output to be written to either stdout or stderr, defaulting to stdout. Can be extended with support for files later, if desired. Useful for #401 to get more detailed output --------- Co-authored-by: DaniPopes <[email protected]>
3 tasks
onbjerg
force-pushed
the
onbjerg/lsp-scaffolding
branch
from
51051d1 to
6a28652
Compare
CodSpeed Performance ReportMerging #401 will not alter performanceComparing Summary
|
onbjerg
force-pushed
the
onbjerg/lsp-scaffolding
branch
from
6a28652 to
6b3b622
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a basic LSP exposed as
solar lsp. The default behavior forsolaris still to compile.The LSP itself is implemented as a thin VFS that sits on top of files on disk. It's pretty dumb, so every time a file is changed, the entirety of the project is reparsed and relowered. Diagnostics from this process is published to the client.
The VFS itself makes use of ropes for file content.
The structure is heavily inspired by
rust-analyzer, albeit with some simplifications given Solar is pretty fast and Solidity projects are usually fairly small.Closes #417