Skip to content

chore(tracing): export tracing-appender crate#9590

Merged
shekhirin merged 1 commit into
mainfrom
alexey/tracing-appender-export
Jul 17, 2024
Merged

chore(tracing): export tracing-appender crate#9590
shekhirin merged 1 commit into
mainfrom
alexey/tracing-appender-export

Conversation

@shekhirin
Copy link
Copy Markdown
Member

Otherwise the return type is unreachable without an additional dependency

fn init(self) -> eyre::Result<Option<WorkerGuard>>;

@shekhirin shekhirin added C-debt A clean up/refactor of existing code A-observability Related to tracing, metrics, logs and other observability tools labels Jul 17, 2024
@shekhirin shekhirin requested a review from mattsse July 17, 2024 17:33
@shekhirin shekhirin requested a review from onbjerg as a code owner July 17, 2024 17:33
Copy link
Copy Markdown
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable

@shekhirin shekhirin added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit 5c4ce3b Jul 17, 2024
@shekhirin shekhirin deleted the alexey/tracing-appender-export branch July 17, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-observability Related to tracing, metrics, logs and other observability tools C-debt A clean up/refactor of existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants