Skip to content

fix(prune): saturating subtract for genesis deposit contract block#9584

Merged
shekhirin merged 3 commits into
mainfrom
alexey/prune-mode-overflow
Jul 17, 2024
Merged

fix(prune): saturating subtract for genesis deposit contract block#9584
shekhirin merged 3 commits into
mainfrom
alexey/prune-mode-overflow

Conversation

@shekhirin
Copy link
Copy Markdown
Member

@shekhirin shekhirin commented Jul 17, 2024

Deposit contract can be deployed on block 0, meaning that we will have a prune mode for receipts PruneMode::Before(0)

reth/crates/chainspec/src/spec.rs

Lines 94 to 98 in 651b0d1

deposit_contract: Some(DepositContract::new(
address!("4242424242424242424242424242424242424242"),
0,
b256!("649bbc62d0e31342afea4e5cd82d4049e7e1ee912fc0889aa790803be39038c5"),
)),

On debug builds, it causes a panic.

@shekhirin shekhirin added C-bug An unexpected or incorrect behavior A-pruning Related to pruning or full node labels Jul 17, 2024
@shekhirin shekhirin requested a review from joshieDo as a code owner July 17, 2024 13:26
@shekhirin shekhirin changed the title Alexey/prune mode overflow fix(prune): saturating subtract for genesis deposit contract prune mode Jul 17, 2024
@shekhirin shekhirin changed the title fix(prune): saturating subtract for genesis deposit contract prune mode fix(prune): saturating subtract for genesis deposit contract block Jul 17, 2024
@shekhirin shekhirin requested review from emhane and mattsse July 17, 2024 14:12
@mattsse mattsse added this pull request to the merge queue Jul 17, 2024
@shekhirin shekhirin removed this pull request from the merge queue due to a manual request Jul 17, 2024
@shekhirin shekhirin enabled auto-merge July 17, 2024 18:39
@shekhirin shekhirin added this pull request to the merge queue Jul 17, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 17, 2024
@shekhirin shekhirin added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit 5cd22b5 Jul 17, 2024
@shekhirin shekhirin deleted the alexey/prune-mode-overflow branch July 17, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@onbjerg onbjerg onbjerg approved these changes

@mattsse mattsse mattsse approved these changes

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@emhane emhane Awaiting requested review from emhane

Assignees

No one assigned

Labels

A-pruning Related to pruning or full node C-bug An unexpected or incorrect behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shekhirin @onbjerg @mattsse