Skip to content

feat: BackFillJobStream#9578

Merged
mattsse merged 6 commits into
paradigmxyz:mainfrom
loocapro:async-backfill-job
Jul 18, 2024
Merged

feat: BackFillJobStream#9578
mattsse merged 6 commits into
paradigmxyz:mainfrom
loocapro:async-backfill-job

Conversation

@loocapro
Copy link
Copy Markdown
Contributor

Closes: #9179

Comment thread crates/exex/exex/src/backfill_stream.rs Outdated
@loocapro loocapro marked this pull request as ready for review July 17, 2024 12:51
@loocapro loocapro requested a review from mattsse July 17, 2024 12:51
@shekhirin shekhirin added C-enhancement New feature or request A-exex Execution Extensions labels Jul 17, 2024
Copy link
Copy Markdown
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more nits, but this is pretty great!

Comment thread crates/exex/exex/src/backfill/stream.rs Outdated
Comment thread crates/exex/exex/src/backfill/stream.rs Outdated
Comment thread crates/exex/exex/src/backfill/stream.rs Outdated
Comment thread crates/exex/exex/src/backfill/stream.rs Outdated
loocapro and others added 3 commits July 18, 2024 09:56
@loocapro loocapro requested a review from mattsse July 18, 2024 08:14
Copy link
Copy Markdown
Member

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only nits, looks good!

Comment thread crates/exex/exex/src/backfill/stream.rs Outdated
Comment thread crates/exex/exex/src/backfill/stream.rs
@mattsse mattsse added this pull request to the merge queue Jul 18, 2024
Merged via the queue into paradigmxyz:main with commit 43ffb83 Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-exex Execution Extensions C-enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stream wrapper type for iterators

3 participants