chore(no_std): fixed no_std compiler errors in reth-primitives-traits#9572
Merged
mattsse merged 6 commits intoJul 17, 2024
Merged
Conversation
martinezjorge
changed the title
no_std compiler errors in reth-primitive-traits crateno_std compiler errors in reth-primitives-traits
mattsse
requested changes
Jul 17, 2024
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
what we also need is setting this crate's default-features = false on the workspace level cargo.toml
mattsse
force-pushed
the
fix-no-std-compiler-errors-in-primitive-traits
branch
2 times, most recently
from
7c105bd to
fbeaba1
Compare
mattsse
approved these changes
Jul 17, 2024
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
lgtm,
I did some finishing touchups because this pr is required by something I'm working on.
mattsse
force-pushed
the
fix-no-std-compiler-errors-in-primitive-traits
branch
2 times, most recently
from
4a004f5 to
f45bddd
Compare
mattsse
force-pushed
the
fix-no-std-compiler-errors-in-primitive-traits
branch
from
f45bddd to
e461ec5
Compare
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 22, 2026
…its` (paradigmxyz/reth#9572) Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps progress #9478