feat(storage): use roaring bitmaps for history tables #5463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-enhancement
shekhirin
force-pushed
the
alexey/roaring-bitmaps
branch
from
9f7895c to
bad45bc
Compare
shekhirin
force-pushed
the
alexey/roaring-bitmaps
branch
from
4dc6474 to
7f3a7b5
Compare
shekhirin
force-pushed
the
alexey/roaring-bitmaps
branch
5 times, most recently
from
1ac1618 to
1918293
Compare
shekhirin
force-pushed
the
alexey/roaring-bitmaps
branch
from
1918293 to
1764a25
Compare
shekhirin
force-pushed
the
alexey/roaring-bitmaps
branch
from
3cfe9a9 to
fa793aa
Compare
shekhirin
force-pushed
the
alexey/roaring-bitmaps
branch
from
2082bfe to
b237b23
Compare
shekhirin
force-pushed
the
alexey/roaring-bitmaps
branch
from
b237b23 to
9b1e39a
Compare
shekhirin
force-pushed
the
alexey/roaring-bitmaps
branch
from
ffff7ea to
500aba9
Compare
joshieDo
reviewed
Nov 24, 2023
| let rank = chunk.rank(self.block_number as usize); | ||
| // Adjust the rank, so that we have the rank of the first entry strictly before our | ||
| // block (not equal to it). | ||
| if rank.checked_sub(1).and_then(|rank| chunk.select(rank)) == Some(self.block_number) { |
joshieDo
approved these changes
Nov 24, 2023
Collaborator
joshieDo
left a comment
joshieDo
left a comment
There was a problem hiding this comment.
faster, smaller lfg. i'd just remove any mention of elias wrt to this from the codebase, maybe some reference to this PR should be enough on IntegerList
Collaborator
Author
yeah, already done, only snapshots and benches left 
|
github-actions
bot
added
the
S-stale
shekhirin
added
M-prevent-stale
shekhirin
force-pushed
the
alexey/roaring-bitmaps
branch
from
239c804 to
500aba9
Compare
shekhirin
force-pushed
the
alexey/roaring-bitmaps
branch
from
911aee0 to
87b8cb1
Compare
Member
|
Just confirming that we want this and we'll release alongside the next alpha which breaks the DB. |
Collaborator
Author
|
@gakonst correct. This PR can already be reviewed, because it'll get merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance benchmarks
X axis is the random delta in the range of
x-x/2..=x+x/2between 2000 integersSize benchmarks
Mainnet Archive Node
AccountHistoryStorageHistorySepolia Full Node
AccountHistoryStorageHistory