Skip to content

chore(primitives): derive Compact for StageUnitCheckpoint #3452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2023
Merged

chore(primitives): derive Compact for StageUnitCheckpoint #3452

merged 1 commit into from
Sep 25, 2023

Conversation

@shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Jun 28, 2023 •
edited
Loading

Made possible by #3419

@shekhirin shekhirin added A-staged-sync Related to staged sync (pipelines and stages) C-debt A clean up/refactor of existing code labels Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023 •
edited
Loading

Codecov Report

Merging #3452 (5db149b) into main (bb57556) will increase coverage by 1.00%.
Report is 311 commits behind head on main.
The diff coverage is 100.00%.

Impacted file tree graph

Files Changed Coverage Δ
crates/primitives/src/stage/checkpoints.rs 78.12% <100.00%> (-5.59%) ⬇️

... and 249 files with indirect coverage changes

Flag Coverage Δ
integration-tests 17.53% <0.00%> (+1.24%) ⬆️
unit-tests 65.05% <100.00%> (+0.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 27.43% <ø> (+3.97%) ⬆️
blockchain tree 83.02% <ø> (+1.66%) ⬆️
pipeline 91.00% <ø> (+2.98%) ⬆️
storage (db) 75.46% <ø> (+1.46%) ⬆️
trie 95.83% <ø> (+0.19%) ⬆️
txpool 50.98% <ø> (-0.39%) ⬇️
networking 78.88% <ø> (+0.98%) ⬆️
rpc 61.59% <ø> (+3.53%) ⬆️
consensus 67.29% <ø> (+4.21%) ⬆️
revm 30.81% <ø> (-4.34%) ⬇️
payload builder 6.66% <ø> (-0.18%) ⬇️
primitives 89.04% <100.00%> (+0.43%) ⬆️

@joshieDo
Copy link
Collaborator

joshieDo commented Jun 28, 2023

Would wait on #3341 (comment) since it's related

@shekhirin shekhirin added the S-breaking This PR includes a breaking change label Jul 3, 2023
@shekhirin shekhirin marked this pull request as ready for review July 3, 2023 14:25
@shekhirin shekhirin requested a review from gakonst as a code owner July 3, 2023 14:25
mattsse
mattsse approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

blocking PR is merged,

It's a breaking change, @joshieDo tested it.

oh should we hold off merging this then?

@onbjerg
Copy link
Collaborator

onbjerg commented Jul 5, 2023

@mattsse yeah hold off

@shekhirin
Copy link
Collaborator Author

shekhirin commented Jul 5, 2023

emphasised the do not merge message in pr desc

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Jul 22, 2023
@github-actions github-actions bot closed this Jul 30, 2023
@shekhirin shekhirin reopened this Jul 30, 2023
@shekhirin shekhirin added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels Jul 30, 2023
@shekhirin shekhirin changed the base branch from main to breaking-changes September 20, 2023 13:11
@shekhirin shekhirin requested a review from joshieDo September 20, 2023 13:12
onbjerg
onbjerg approved these changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to merge into breaking changes branch

@shekhirin shekhirin merged commit 55bb9db into breaking-changes Sep 25, 2023
@shekhirin shekhirin deleted the alexey/stage-unit-checkpoint-derive-compact branch September 25, 2023 12:18
rkrasiuk pushed a commit that referenced this pull request Oct 18, 2023
@shekhirin @rkrasiuk
chore(primitives): derive Compact for StageUnitCheckpoint (#3452)
f92e388
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@onbjerg onbjerg onbjerg approved these changes

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst

@joshieDo joshieDo Awaiting requested review from joshieDo

Assignees

No one assigned

Labels

A-staged-sync Related to staged sync (pipelines and stages) C-debt A clean up/refactor of existing code M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity S-breaking This PR includes a breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shekhirin @joshieDo @onbjerg @mattsse