refactor: replace GenericArray with regular arrays in ECIES #19563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary GenericArray dependency from the ECIES implementation. The HeaderBytes type alias (GenericArray<u8, U16>) has been replaced with standard Rust arrays ([u8; 16]), simplifying the code and reducing dependencies. This change removes the generic-array and typenum dependencies from reth-ecies while maintaining the same functionality.
mattsse
added
C-debt
shekhirin
approved these changes
Nov 6, 2025
yongkangc
pushed a commit
that referenced
this pull request
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HeaderBytestype alias usingGenericArray<u8, U16>has been replaced with standard Rust arrays[u8; 16]. This simplifies the code and removes unnecessary dependencies.Changes
HeaderBytestype alias frommac.rsMAC::update_headerto accept&[u8; 16]instead of&GenericArray<u8, U16>algorithm.rsto use regular arraysgeneric-arrayandtypenumdependencies fromreth-eciesgeneric-arrayfrom rootCargo.toml(no longer needed by any crate)The functionality remains identical, just with simpler types and fewer dependencies.