test(static-file): StaticFileSegment string and serde roundtrips #19561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-test
shekhirin
force-pushed
the
alexey/static-file-segment-strings
branch
2 times, most recently
from
fa42d49 to
d6087a1
Compare
shekhirin
force-pushed
the
alexey/static-file-segment-strings
branch
from
d6087a1 to
3603857
Compare
mattsse
approved these changes
Nov 6, 2025
Comment on lines
43
to
44
| // `strum` doesn't generate a comment for `into_str` when using `IntoStaticStr` derive | ||
| // macro, so we need to manually implement it. |
Collaborator
There was a problem hiding this comment.
what does generate a comment mean?
Collaborator
Author
There was a problem hiding this comment.
a doc comment, so the clippy is reporting a warning
afaik there's no way to silence missing_docs just for one method, and i don't want to silence it for the whole file
shekhirin
commented
Nov 6, 2025
yongkangc
pushed a commit
that referenced
this pull request
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StaticFileSegmentstring and serde roundtrips that are used in filenames and segment headersstrum(serialize = "...")attributes