Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 51 additions & 6 deletions crates/net/network/src/fetch/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ pub use client::FetchClient;
use crate::{message::BlockRequest, session::BlockRangeInfo};
use alloy_primitives::B256;
use futures::StreamExt;
use reth_eth_wire::{EthNetworkPrimitives, GetBlockBodies, GetBlockHeaders, NetworkPrimitives};
use reth_eth_wire::{
Capabilities, EthNetworkPrimitives, GetBlockBodies, GetBlockHeaders, NetworkPrimitives,
};
use reth_network_api::test_utils::PeersHandle;
use reth_network_p2p::{
error::{EthResponseValidator, PeerRequestResult, RequestError, RequestResult},
Expand Down Expand Up @@ -80,6 +82,7 @@ impl<N: NetworkPrimitives> StateFetcher<N> {
peer_id: PeerId,
best_hash: B256,
best_number: u64,
capabilities: Arc<Capabilities>,
timeout: Arc<AtomicU64>,
range_info: Option<BlockRangeInfo>,
) {
Expand All @@ -89,6 +92,7 @@ impl<N: NetworkPrimitives> StateFetcher<N> {
state: PeerState::Idle,
best_hash,
best_number,
capabilities,
timeout,
last_response_likely_bad: false,
range_info,
Expand Down Expand Up @@ -341,6 +345,9 @@ struct Peer {
best_hash: B256,
/// Tracks the best number of the peer.
best_number: u64,
/// Capabilities announced by the peer.
#[allow(dead_code)]
capabilities: Arc<Capabilities>,
/// Tracks the current timeout value we use for the peer.
timeout: Arc<AtomicU64>,
/// Tracks whether the peer has recently responded with a likely bad response.
Expand Down Expand Up @@ -511,8 +518,23 @@ mod tests {
// Add a few random peers
let peer1 = B512::random();
let peer2 = B512::random();
fetcher.new_active_peer(peer1, B256::random(), 1, Arc::new(AtomicU64::new(1)), None);
fetcher.new_active_peer(peer2, B256::random(), 2, Arc::new(AtomicU64::new(1)), None);
let capabilities = Arc::new(Capabilities::from(vec![]));
fetcher.new_active_peer(
peer1,
B256::random(),
1,
Arc::clone(&capabilities),
Arc::new(AtomicU64::new(1)),
None,
);
fetcher.new_active_peer(
peer2,
B256::random(),
2,
Arc::clone(&capabilities),
Arc::new(AtomicU64::new(1)),
None,
);

let first_peer = fetcher.next_best_peer().unwrap();
assert!(first_peer == peer1 || first_peer == peer2);
Expand All @@ -539,9 +561,31 @@ mod tests {

let peer2_timeout = Arc::new(AtomicU64::new(300));

fetcher.new_active_peer(peer1, B256::random(), 1, Arc::new(AtomicU64::new(30)), None);
fetcher.new_active_peer(peer2, B256::random(), 2, Arc::clone(&peer2_timeout), None);
fetcher.new_active_peer(peer3, B256::random(), 3, Arc::new(AtomicU64::new(50)), None);
let capabilities = Arc::new(Capabilities::from(vec![]));
fetcher.new_active_peer(
peer1,
B256::random(),
1,
Arc::clone(&capabilities),
Arc::new(AtomicU64::new(30)),
None,
);
fetcher.new_active_peer(
peer2,
B256::random(),
2,
Arc::clone(&capabilities),
Arc::clone(&peer2_timeout),
None,
);
fetcher.new_active_peer(
peer3,
B256::random(),
3,
Arc::clone(&capabilities),
Arc::new(AtomicU64::new(50)),
None,
);

// Must always get peer1 (lowest timeout)
assert_eq!(fetcher.next_best_peer(), Some(peer1));
Expand Down Expand Up @@ -609,6 +653,7 @@ mod tests {
peer_id,
Default::default(),
Default::default(),
Arc::new(Capabilities::from(vec![])),
Default::default(),
None,
);
Expand Down
1 change: 1 addition & 0 deletions crates/net/network/src/state.rs
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ impl<N: NetworkPrimitives> NetworkState<N> {
peer,
status.blockhash,
block_number,
Arc::clone(&capabilities),
timeout,
range_info,
);
Expand Down
Loading