Skip to content

Conversation

@davidjsonn
Copy link
Contributor

Tests in reth-stages-types weren't compiling due to missing vec! macro import and some dev dependencies.

Fixed by:

  • Adding #[cfg(test)] use alloc::vec for test builds
  • Adding missing modular-bitfield and reth-trie-common[reth-codec] to dev-dependencies

cargo test -p reth-stages-types --lib now works properly

Copy link
Collaborator

@mediocregopher mediocregopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that tests were previously broken and this does fix them

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Nov 6, 2025
@shekhirin shekhirin added this pull request to the merge queue Nov 6, 2025
Merged via the queue into paradigmxyz:main with commit 7cc4fdf Nov 6, 2025
42 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Nov 6, 2025
@davidjsonn davidjsonn deleted the fix/stages-types-compilation branch November 7, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants