chore: BuiltPayloadExecutedBlock #19430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a copy of the ExecutedBlock type for use specifically in payload building. This will let us diverge the ExecutedBlock type which is used for validation without affecting performance of block building.
mattsse
reviewed
Nov 6, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
this separation makes sense imo
we could/should support either representation here
mediocregopher
requested review from
Rjected,
fgimenez,
gakonst,
klkvr and
shekhirin
as code owners
mattsse
requested changes
Nov 6, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
this makes sense
very pedantic nits
mattsse
added
M-changelog
mediocregopher
deleted the
mediocregopher/payload-builder-executed-block
branch
yongkangc
pushed a commit
that referenced
this pull request
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a copy of the ExecutedBlock type for use specifically in payload building. This will let us diverge the ExecutedBlock type which is used for validation without affecting performance of block building.