refactor(ipc): simplify RpcServiceCfg from enum to struct #19180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidjsonn
requested review from
Rjected,
RomanHodulak and
mattsse
as code owners
mattsse
approved these changes
Oct 21, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
fair,
I think this is coming from ported jsonrpsee ws code, we can change this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts RpcServiceCfg from an enum with two variants to a simple struct.
The OnlyCalls variant was never used in practice (had #[allow(dead_code)] since creation) and only CallsAndSubscriptions was ever instantiated. This change removes the unnecessary complexity of pattern matching and error handling for subscriptions that would never occur.
The IPC server always needs full RPC functionality including subscriptions, so having a "calls only" mode was theoretical overhead without practical benefit.