chore: remove total difficulty from HeaderProvider
#19151
Conversation
joshieDo
added
C-debt
| hash, | ||
| difficulty: header.difficulty(), | ||
| total_difficulty, | ||
| total_difficulty: U256::ZERO, |
There was a problem hiding this comment.
im guessing so, but is this okay?
There was a problem hiding this comment.
I think this should be fine, in p2p this is deprecated as of eth/69 and the node builder only uses the Head to get the timestamp
joshieDo
changed the title
TTD from HeaderProviderHeaderProvider
joshieDo
changed the title
HeaderProviderHeaderProvider
joshieDo
requested review from
Rjected,
RomanHodulak,
gakonst,
klkvr,
mattsse,
mediocregopher,
rakita,
rkrasiuk and
shekhirin
as code owners
Rjected
left a comment
Rjected
left a comment
There was a problem hiding this comment.
just a q about simplifying append_header args otherwise lgtm
|
|
||
| // Append to Headers segment | ||
| writer.append_header(header, td, header_hash)?; | ||
| writer.append_header(header, U256::ZERO, header_hash)?; |
There was a problem hiding this comment.
do we ever call this with something nonzero after this PR? if not then maybe we should just remove the arg?
There was a problem hiding this comment.
yeah I think we should remove this from the function arg entirely
| hash, | ||
| difficulty: header.difficulty(), | ||
| total_difficulty, | ||
| total_difficulty: U256::ZERO, |
There was a problem hiding this comment.
I think this should be fine, in p2p this is deprecated as of eth/69 and the node builder only uses the Head to get the timestamp
|
|
||
| // Append to Headers segment | ||
| writer.append_header(header, td, header_hash)?; | ||
| writer.append_header(header, U256::ZERO, header_hash)?; |
There was a problem hiding this comment.
yeah I think we should remove this from the function arg entirely
StorageApiera_utils::calculate_td_by_numberso we are able to generate era files with the same checksums. slightly expensive, since it has to iterate through all headers up to num.static_file_provider.append_headernow always sets TTD column to zero. This has the side-effect that static files will have a different checksum after this PR.closes #16586