fix: remove tautological assertions in validator tests #19134
Merged
+4
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor tests to focus on execution without asserting results.
sky-coderay
requested review from
Rjected,
fgimenez,
mattsse,
mediocregopher,
rkrasiuk and
yongkangc
as code owners
mediocregopher
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assertions
assert!(result.is_ok() || result.is_err())are meaningless tautologies that are always true for any Result type. The existing comments clearly indicate the tests' actual intent was to verify execution without panic, not specific results, but the assertions contradicted this by pretending to validate outcomes. Replaced with clear comments and_resultprefixes to align code with its documented purpose.