refactor: rename disable_caching_and_prewarming to disable_prewarming #19072
+19
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The field name was misleading as it only controls prewarming behavior, not caching. This renames the field and related methods to accurately reflect what the configuration option does. Changes: - Renamed TreeConfig field from disable_caching_and_prewarming to disable_prewarming - Updated all method names and documentation - Added CLI flag alias for backward compatibility (--engine.disable-caching-and-prewarming)
shekhirin
requested review from
Rjected,
fgimenez,
gakonst,
klkvr,
mattsse,
mediocregopher,
rkrasiuk and
yongkangc
as code owners
shekhirin
added
C-debt
mattsse
approved these changes
Oct 16, 2025
Member
|
Nice one |
emhane
pushed a commit
to op-rs/op-reth
that referenced
this pull request
Oct 20, 2025
emhane
pushed a commit
to op-rs/op-reth
that referenced
this pull request
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field name was misleading as it only controls prewarming behavior, not caching. This renames the field and related methods to accurately reflect what the configuration option does.