fix: include serde-bincode-compat in db-api #19043
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Maybe we should just require reth-optimism-primitives with the serde-bincode-compat trait in reth-optimism-exex though... |
Contributor
Author
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's another issue with compiling due to missing
serde-bincode-compatfeature inreth-optimism-primitives.The dep chain is:
reth-optimism-exexrequiresreth-exexrequires (needs serde bincode compact impl here due toExExNotificationserialization/deserialization)reth-exex-typesrequiresreth-chain-staterequiresreth-storage-apirequiresreth-db-apirequiresreth-optimism-primitivesbut this doesn't have serde-bincode-compat by defaultI think we should just enable
serde-bincode-compatonreth-db-api's dependency ofreth-optimism-primitives. Otherwise, we'd have to add features to each of these crates to enable/disable the serde-bincode-compatfeature.