fix(net): correct error messages for decrypt and header paths #19039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
pushed a commit
to op-rs/op-reth
that referenced
this pull request
Oct 20, 2025
emhane
pushed a commit
to op-rs/op-reth
that referenced
this pull request
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change corrects two misleading ECIES error messages to match the actual failure sites and improve debugging clarity. TagCheckDecryptFailed was incorrectly worded as “tag check failure in read_header” despite only being raised in the ECIES decrypt path (EncryptedMessage::check_integrity during auth/ack payload decryption), and InvalidHeader was incorrectly worded as “invalid body data” although it is raised exclusively by read_header for malformed/undersized RLPx headers