feat(engine): improve payload validator tracing spans #18960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
requested review from
Rjected,
fgimenez,
mattsse,
mediocregopher,
rkrasiuk and
yongkangc
as code owners
mediocregopher
approved these changes
Oct 13, 2025
Collaborator
mediocregopher
left a comment
mediocregopher
left a comment
There was a problem hiding this comment.
Does setting the level to trace mean that these fields won't get included in e.g. WARN logs? If so maybe it would be useful to also have these applied to all logs? Having more context in each individual log makes them easier to use imo
shekhirin
force-pushed
the
alexey/payload-validator-spans
branch
from
4e2c21c to
2edfca4
Compare
shekhirin
force-pushed
the
alexey/payload-validator-spans
branch
from
2edfca4 to
a2ca4a3
Compare
shekhirin
force-pushed
the
alexey/payload-validator-spans
branch
from
4aad039 to
32575f8
Compare
shekhirin
force-pushed
the
alexey/payload-validator-spans
branch
3 times, most recently
from
5f07b20 to
a284629
Compare
shekhirin
force-pushed
the
alexey/payload-validator-spans
branch
from
a284629 to
d2f02a5
Compare
yongkangc
approved these changes
Oct 17, 2025
| let block_num_hash = input.num_hash(); | ||
|
|
||
| trace!(target: "engine::tree", block=?block_num_hash, parent=?parent_hash, "Fetching block state provider"); | ||
| trace!(target: "engine::tree::payload_validator", "Fetching block state provider"); |
Member
There was a problem hiding this comment.
do we not want the block num hash here?
Member
There was a problem hiding this comment.
That info will be added by the instrument call at the top of the fn
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
emhane
pushed a commit
to op-rs/op-reth
that referenced
this pull request
Oct 20, 2025
) Co-authored-by: Claude <[email protected]> Co-authored-by: Dan Cline <[email protected]>
emhane
pushed a commit
to op-rs/op-reth
that referenced
this pull request
Oct 20, 2025
) Co-authored-by: Claude <[email protected]> Co-authored-by: Dan Cline <[email protected]>
mediocregopher
added a commit
that referenced
this pull request
Oct 20, 2025
This reverts commit 4a32bc0.
mediocregopher
added a commit
that referenced
this pull request
Oct 20, 2025
This reverts commit 4a32bc0.
shekhirin
pushed a commit
that referenced
this pull request
Oct 30, 2025
shekhirin
added a commit
that referenced
this pull request
Oct 30, 2025
This reverts commit 4a32bc0.
shekhirin
added a commit
that referenced
this pull request
Oct 30, 2025
This reverts commit 4a32bc0.
shekhirin
added a commit
that referenced
this pull request
Oct 30, 2025
This reverts commit 4a32bc0.
shekhirin
added a commit
that referenced
this pull request
Oct 30, 2025
This reverts commit 4a32bc0.
shekhirin
added a commit
that referenced
this pull request
Oct 30, 2025
This reverts commit 4a32bc0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #18892
This PR has two main changes:
instrumentmacro calls now have adebuglevel specified. This is done to prevent losing context forDEBUGlevel events — previously if theinstrumentmacro created a span with levelTRACE, thenDEBUGevents won't have this span as a parent, unless the env filter is specified to include theseTRACEspans. Just creating a span doesn't emit an event itself, so it doesn't make the stdout noisier.engine::tree*target is created, giving us a better overview of payload validation pipeline