refactor(engine): simplify InvalidBlockWitnessHook::on_invalid_block for better testability #18696

0xKarl98 · 2025-09-25T06:52:09Z

@yongkangc Please check if it meets the simplification requirement

Copilot

Pull Request Overview

This PR refactors the InvalidBlockWitnessHook::on_invalid_block method by breaking it down into smaller, focused functions to improve testability and maintainability. The refactoring separates concerns into distinct methods for data collection, proof generation, witness operations, and validation.

Extracts block re-execution logic into re_execute_block method
Splits validation logic into separate methods for bundle state and state root validation
Adds comprehensive test coverage for the newly extracted methods

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.

File	Description
crates/engine/invalid-block-hooks/src/witness.rs	Refactored main hook implementation by extracting helper methods and adding extensive test coverage
crates/engine/invalid-block-hooks/Cargo.toml	Added test dependencies required for the new test suite

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-25T13:55:14Z

crates/engine/invalid-block-hooks/src/witness.rs

+#[cfg(test)]
+mod tests {
+    use super::*;
+    use reth_revm::db::{BundleAccount,BundleState};


Missing space after comma in the import statement. Should be BundleAccount, BundleState.

Copilot · 2025-09-25T13:55:15Z

crates/engine/invalid-block-hooks/src/witness.rs

+struct DataCollector;
+
+impl DataCollector {
+    fn collect(mut db: State<StateProviderDatabase<Box<dyn StateProvider>>>) -> eyre::Result<(BTreeMap<B256, Bytes>, BTreeMap<B256, Bytes>, reth_trie::HashedPostState, BundleState)> {


[nitpick] The return type tuple is complex and unclear. Consider creating a struct to represent the collected data with named fields like codes, preimages, hashed_state, and bundle_state.

Copilot · 2025-09-25T13:55:15Z

crates/engine/invalid-block-hooks/src/witness.rs

+struct ProofGenerator;
+
+impl ProofGenerator {
+    fn generate(codes: BTreeMap<B256, Bytes>, preimages: BTreeMap<B256, Bytes>, hashed_state: reth_trie::HashedPostState, state_provider: Box<dyn StateProvider>) -> eyre::Result<ExecutionWitness> {


[nitpick] This function has too many parameters. Consider using a struct to group related parameters or accepting the output from DataCollector::collect directly.

Copilot · 2025-09-25T13:55:15Z

crates/engine/invalid-block-hooks/src/witness.rs

+        Ok(path)
+    }

+    fn save_diff<T: std::fmt::Debug>(&self, filename: &str, old: &T, new: &T) -> eyre::Result<PathBuf> {


The generic constraint should use PartialEq in addition to Debug to ensure the values can be compared, or document that this function only displays differences without verifying they actually differ.

Suggested change

fn save_diff<T: std::fmt::Debug>(&self, filename: &str, old: &T, new: &T) -> eyre::Result<PathBuf> {

fn save_diff<T: std::fmt::Debug + PartialEq>(&self, filename: &str, old: &T, new: &T) -> eyre::Result<PathBuf> {

yongkangc

overall much simpler, left some questions.

Think the logic is not exactly equivalent?

yongkangc · 2025-09-26T02:28:31Z

crates/engine/invalid-block-hooks/src/witness.rs

    }

-    fn save_file<T: Serialize>(&self, filename: String, value: &T) -> eyre::Result<PathBuf> {
+    fn save_json<T: serde::Serialize>(&self, filename: &str, data: &T) -> eyre::Result<PathBuf> {


Suggested change

fn save_json<T: serde::Serialize>(&self, filename: &str, data: &T) -> eyre::Result<PathBuf> {

fn save_file<T: Serialize>(&self, filename: &str, data: &T) -> eyre::Result<PathBuf> {

Think it might be better to reduce changes here. Don't see a reason to change file name?

Yeah i was kind of thinking to combine save_json and save_diff into one function , as to reduce the loc here .
But seems should keep them the same as before would be better

yongkangc · 2025-09-26T02:29:38Z

crates/engine/invalid-block-hooks/src/witness.rs

+    fn save_diff<T: std::fmt::Debug>(&self, filename: &str, old: &T, new: &T) -> eyre::Result<PathBuf> {
+        let path = self.output_directory.join(filename);
+        let content = Comparison::new(old, new).to_string();
+        File::create(&path)?.write_all(content.as_bytes())?;
        Ok(path)
    }


Is there a reason why we cant keep it simliar to the prev implementation here?

i.e

/// Saves the diff of two values into a file with the given name in the output directory. fn save_diff<T: PartialEq + Debug>( &self, filename: String, original: &T, new: &T, ) -> eyre::Result<PathBuf> { let path = self.output_directory.join(filename); let diff = Comparison::new(original, new); File::create(&path)?.write_all(diff.to_string().as_bytes())?; Ok(path) }

Yeah will restore it

yongkangc · 2025-09-26T02:30:29Z

crates/engine/invalid-block-hooks/src/witness.rs

-            &response,
-        )?;
+    /// Handles witness generation, saving, and comparison with healthy node
+    fn handle_witness_operations(


i like the idea of this function, makes it much easier to see

yongkangc · 2025-09-26T02:31:39Z

crates/engine/invalid-block-hooks/src/witness.rs

-        let codes = db
-            .cache
-            .contracts
-            .values()
-            .map(|code| code.original_bytes())
-            .chain(
-                // cache state does not have all the contracts, especially when
-                // a contract is created within the block
-                // the contract only exists in bundle state, therefore we need
-                // to include them as well
-                bundle_state.contracts.values().map(|code| code.original_bytes()),
-            )
-            .collect();
-
-        // Grab all account proofs for the data accessed during block execution.
-        //
-        // Note: We grab *all* accounts in the cache here, as the `BundleState` prunes
-        // referenced accounts + storage slots.
-        let mut hashed_state = db.database.hashed_post_state(&bundle_state);
-        for (address, account) in db.cache.accounts {


where did all these function logic go?

This locates at the DataCollector impl

yongkangc · 2025-09-26T02:33:10Z

also @0xKarl98 could you also fix the ci as well?

0xKarl98 · 2025-09-29T11:19:39Z

@yongkangc May you review this again ?

yongkangc · 2025-09-29T11:22:04Z

crates/engine/invalid-block-hooks/src/witness.rs

+struct DataCollector;

-#[derive(Debug, PartialEq, Eq)]
-struct BundleStateSorted {
-    /// Account state
-    pub state: BTreeMap<Address, BundleAccountSorted>,
-    /// All created contracts in this block.
-    pub contracts: BTreeMap<B256, Bytecode>,
-    /// Changes to revert
-    ///
-    /// **Note**: Inside vector is *not* sorted by address.
-    ///
-    /// But it is unique by address.
-    pub reverts: Vec<Vec<(Address, AccountRevertSorted)>>,
-    /// The size of the plain state in the bundle state
-    pub state_size: usize,
-    /// The size of reverts in the bundle state
-    pub reverts_size: usize,
-}
+impl DataCollector {


can we remove this struct? seems like the struct might be a shallwo abstraction

You mean DataCollector ? If so , will do , and will also deal with proof generator in the same way

0xKarl98 · 2025-09-29T12:31:40Z

@yongkangc Have done that requested changes

yongkangc · 2025-09-29T11:22:11Z

crates/engine/invalid-block-hooks/src/witness.rs

-    pub reverts_size: usize,
-}
+impl DataCollector {
+    fn collect(


could we leave clear and concise docstring for this?

This part of code has been removed in previous touchups

yongkangc · 2025-09-29T11:23:26Z

crates/engine/invalid-block-hooks/src/witness.rs

+type CollectionResult =
+    (BTreeMap<B256, Bytes>, BTreeMap<B256, Bytes>, reth_trie::HashedPostState, BundleState);
+
+fn sort_bundle_state_for_comparison(bundle_state: &BundleState) -> serde_json::Value {


could we leave a line of docstring here thats clear and concise explaining what this does?

Rjected

thanks! mostly style comments and suggestions about using serde_json::Value so far

Rjected · 2025-10-06T17:13:35Z

crates/engine/invalid-block-hooks/src/witness.rs

+type CollectionResult =
+    (BTreeMap<B256, Bytes>, BTreeMap<B256, Bytes>, reth_trie::HashedPostState, BundleState);
+
+/// Converts bundle state to sorted JSON format for deterministic comparison
+fn sort_bundle_state_for_comparison(bundle_state: &BundleState) -> serde_json::Value {
+    serde_json::json!({
+        "state": bundle_state.state.iter().map(|(addr, acc)| {
+            (addr, serde_json::json!({
+                "info": acc.info,
+                "original_info": acc.original_info,
+                "storage": BTreeMap::from_iter(acc.storage.clone()),
+                "status": acc.status
+            }))
+        }).collect::<BTreeMap<_, _>>(),
+        "contracts": BTreeMap::from_iter(bundle_state.contracts.clone()),
+        "reverts": bundle_state.reverts.iter().map(|block| {
+            block.iter().map(|(addr, rev)| {
+                (addr, serde_json::json!({
+                    "account": rev.account,
+                    "storage": BTreeMap::from_iter(rev.storage.clone()),
+                    "previous_status": rev.previous_status,
+                    "wipe_storage": rev.wipe_storage
+                }))
+            }).collect::<BTreeMap<_, _>>()
+        }).collect::<Vec<_>>(),
+        "state_size": bundle_state.state_size,
+        "reverts_size": bundle_state.reverts_size
+    })


IMO we should not be manually constructing a serde_json::Value ever, if this is supposed to be a serializable version of BundleStateSorted then we should just derive serialize for it

Rjected · 2025-10-06T17:14:33Z

crates/engine/invalid-block-hooks/src/witness.rs

+            // Convert bundle state to sorted format for deterministic comparison
+            let bundle_state_sorted = sort_bundle_state_for_comparison(re_executed_state);
+            let output_state_sorted = sort_bundle_state_for_comparison(original_state);


I preferred the old structs for this

Rjected · 2025-10-06T17:17:27Z

crates/engine/invalid-block-hooks/src/witness.rs

+            if witness != &healthy_node_witness {
+                let diff_path = self.save_diff(
+                    format!("{}.witness.diff", block_prefix),
+                    witness,
+                    &healthy_node_witness,
+                )?;


for this and the other fns where format! calls are used directly as arguments, I preferred the old way because it was more explicit e.g.:

let filename = format!(....); let diff_path = self.save_diff(filename, ...);

Please check it out again

yongkangc

lgtm! @Rjected @shekhirin @mediocregopher any other thoughts?

mediocregopher

LGTM

0xKarl98 · 2025-10-09T16:57:08Z

@yongkangc Think we can merge it now ?

yongkangc · 2025-10-13T05:14:01Z

.github/assets/check_wasm.sh

+  reth-cli-util
+  reth-db
+  reth-db-api
+  reth-ecies
+  reth-network-api
+  reth-nippy-jar
+  reth-node-types
+  reth-rpc-server-types
+  reth-trie-db
+  reth-zstd-compressors


why did we add these?

If not add them , run bash .github/assets/check_wasm.sh will return error and this will resolve the failed WASM while didn't touch other files

This WASM job failure didn't get encountered several days ago

And i have fixed other new lint errors after you approved the merge

We should probably not add these here, and instead figure out why they failed

Have started investigated the failure reason and try not add these :)

0xKarl98 · 2025-10-13T10:42:56Z

@yongkangc Last review , i have just pulled @mediocregopher's new fix on CI

0xKarl98 · 2025-10-13T15:29:15Z

@yongkangc @mediocregopher @Rjected

For this build Volc , i've run the same command on local , it ran successfully :

Can you figure why this fails on github actions ?

Rjected

lgtm other than the check_wasm additions

Rjected · 2025-10-13T16:45:42Z

.github/assets/check_wasm.sh

+  reth-cli-util
+  reth-db
+  reth-db-api
+  reth-ecies
+  reth-network-api
+  reth-nippy-jar
+  reth-node-types
+  reth-rpc-server-types
+  reth-trie-db
+  reth-zstd-compressors


We should probably not add these here, and instead figure out why they failed

0xKarl98 · 2025-10-13T16:55:09Z

lgtm other than the check_wasm additions

Think so , i've swiched codebase to where before i made the merge , i.e. Apply Rejected Suggestions

But this problem persists , there might be some other root causes for this

0xKarl98 · 2025-10-14T02:59:31Z

@yongkangc @Rjected @shekhirin I re-run the Github CI tests , and it turns out that the wasm check run well this time , then i have removed them .

For book/build in CI fails , i checked recent merged commits , they also get operation cancelled in this check

So i think this pr is ready to merge and we'd better to set up another PR to resolve this timeout in book/build CI check !

Rjected · 2025-10-14T20:18:17Z

So i think this pr is ready to merge and we'd better to set up another PR to resolve this timeout in book/build CI check !

yeah given this was failing on main I think that job failing is ok / unrelated to changes here.

0xKarl98 · 2025-10-15T02:26:05Z

@yongkangc May you help merge it again ? :)

stale

* docs: yellowpaper sections in consensus implementation (paradigmxyz#18881) * fix(era-utils): fix off-by-one for Excluded end bound in process_iter (paradigmxyz#18731) Co-authored-by: Roman Hodulák <[email protected]> * refactor: eliminate redundant allocation in precompile cache example (paradigmxyz#18886) * chore: relax `ChainSpec` impls (paradigmxyz#18894) * chore: make clippy happy (paradigmxyz#18900) * fix(trie): Reveal extension child when extension is last remaining child of a branch (paradigmxyz#18891) * chore(node): simplify EngineApiExt bounds by removing redundant constraints (paradigmxyz#18905) * refactor(engine): separate concerns in on_forkchoice_updated for better maintainability (paradigmxyz#18661) Co-authored-by: Nathaniel Bajo <[email protected]> Co-authored-by: YK <[email protected]> Co-authored-by: Brian Picciano <[email protected]> * feat(provider): add get_account_before_block to ChangesetReader (paradigmxyz#18898) * refactor: replace collect().is_empty() with next().is_none() in tests (paradigmxyz#18902) Co-authored-by: Alexey Shekhirin <[email protected]> * ci: cache hive simulator images to reduce prepare-hive job time (paradigmxyz#18899) * docs: duplicate comment in Eip4844PoolTransactionError (paradigmxyz#18858) * chore: align node_config threshold constant (paradigmxyz#18914) * feat: wait for new blocks when build is in progress (paradigmxyz#18831) Co-authored-by: Roman Hodulák <[email protected]> * perf(tree): worker pooling for storage in multiproof generation (paradigmxyz#18887) Co-authored-by: Brian Picciano <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Alexey Shekhirin <[email protected]> * chore(grafana): use precompile address as legend (paradigmxyz#18913) * refactor: remove needless collect() calls in trie tests (paradigmxyz#18937) * fix(examples): change method to launch with debug capabilities (paradigmxyz#18946) * fix(example): launch with debug capabilities (paradigmxyz#18947) * fix(testsuite): Fix unused updates in e2e-test-utils (paradigmxyz#18953) * fix(payload): correct Debug label for PayloadTimestamp in PayloadServiceCommand (paradigmxyz#18954) * chore(rpc): Moves `SequencerMetrics` into `reth-optimism-rpc` (paradigmxyz#18921) * refactor: replace println! with structured logging in test_vectors (paradigmxyz#18956) * refactor(cli): use structured logging (tracing) in p2p command (paradigmxyz#18957) * perf(tree): add elapsed time to parallel state root completion log (paradigmxyz#18959) * fix(trie): Properly upsert into StoragesTrie in repair-trie (paradigmxyz#18941) * fix: misleading error message in db list: show actual table name (paradigmxyz#18896) * fix: remove noisy stderr prints in ERA1 cleanup (EraClient::delete_outside_range) (paradigmxyz#18895) * fix: use max B256 for upper bound in empty-storage check (paradigmxyz#18962) * ci: remove reproducible build from release.yml (paradigmxyz#18958) * chore(rpc): Remove redundant U256::from in suggested_priority_fee (paradigmxyz#18969) * chore(ci): update eest 7594 issue link in hive expected failures file (paradigmxyz#18976) * perf(tests): remove redundant format! in ef-tests run_only (paradigmxyz#18909) * feat(cli): enable traces export via `tracing-otlp` cli arg (paradigmxyz#18242) Co-authored-by: Dan Cline <[email protected]> * feat: allow otlp level to be configurable (paradigmxyz#18981) * chore(optimism): remove unnecessary Debug bounds from header generics (paradigmxyz#18989) * refactor: convert satisfy_base_fee_ids to use closure (paradigmxyz#18979) * chore: bump otlp crates (paradigmxyz#18984) * fix(network): prevent metric leak in outgoing message queue on session teardown (paradigmxyz#18847) * chore: remove unused imports in blockchain_provider (paradigmxyz#18867) Co-authored-by: Matthias Seitz <[email protected]> * fix(stateless): enforce BLOCKHASH ancestor header limit (paradigmxyz#18920) * chore(evm): mark ExecuteOutput as unused and slated for removal (paradigmxyz#18754) * refactor: unify `Pipeline` creation codepaths (paradigmxyz#18955) * fix(engine): flatten storage cache (paradigmxyz#18880) * perf(tree): worker pooling for account proofs (paradigmxyz#18901) Co-authored-by: Brian Picciano <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Alexey Shekhirin <[email protected]> * refactor(storage): fix ChainStateKey enum variant name (paradigmxyz#18992) * refactor(trie): remove proof task manager (paradigmxyz#18934) Co-authored-by: Brian Picciano <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Alexey Shekhirin <[email protected]> * fix: required optimism primitives features in db-api (paradigmxyz#19005) * refactor(engine): simplify InvalidBlockWitnessHook::on_invalid_block for better testability (paradigmxyz#18696) * chore: replace poll_next_unpin loop with poll_recv_many (paradigmxyz#18978) * fix: Set Era pipeline stage to last checkpoint when there is no target (paradigmxyz#19000) * ci: Add tests for Paris scenario in hive.yml (paradigmxyz#19013) * chore: bump book timeout (paradigmxyz#19016) * feat: add metrics for safe and finalized block heights (paradigmxyz#18987) * chore(privitives-traits): remove unused serde derives and camelCase attribute (paradigmxyz#19014) * chore: refactor loop in `add_new_transactions` (paradigmxyz#19006) * chore(ci): bump hive eest to v5.3.0 (paradigmxyz#19021) * feat(devp2p): make eth p2p networkId configurable (paradigmxyz#19020) Co-authored-by: frankudoags <frankudoags.com> * chore: remove unused Args struct from exex-subscription example (paradigmxyz#19019) * feat: add pending sequence as pub (paradigmxyz#19022) * chore: bump alloy-core (paradigmxyz#19026) * fix: unused warnings for tracing (paradigmxyz#19025) * fix: respect cli blob size setting (paradigmxyz#19024) * feat(engine): deprecate TestPipelineBuilder::with_executor_results (paradigmxyz#19017) * perf: background init of workers (paradigmxyz#19012) * chore(ci): update expected failures (paradigmxyz#19034) * fix: use header type generic for mask (paradigmxyz#19037) * fix: correct `Compact` impl for `Option` (paradigmxyz#19042) * chore: increase versioned hash index cache (paradigmxyz#19038) * chore(primitives-traits): relax SignerRecoverable bounds for Extended<B,T> (paradigmxyz#19045) * feat: bump revm (paradigmxyz#18999) * fix: resolve upstream merge Signed-off-by: Gregory Edison <[email protected]> * bump revm * update deps and fix lints * update openvm deps * skip exex wal storage test * pin revm tag scroll-v91 * bump openvm compat --------- Signed-off-by: Gregory Edison <[email protected]> Co-authored-by: josé v <[email protected]> Co-authored-by: Forostovec <[email protected]> Co-authored-by: Roman Hodulák <[email protected]> Co-authored-by: Skylar Ray <[email protected]> Co-authored-by: Arsenii Kulikov <[email protected]> Co-authored-by: Léa Narzis <[email protected]> Co-authored-by: Brian Picciano <[email protected]> Co-authored-by: radik878 <[email protected]> Co-authored-by: William Nwoke <[email protected]> Co-authored-by: Nathaniel Bajo <[email protected]> Co-authored-by: YK <[email protected]> Co-authored-by: Dan Cline <[email protected]> Co-authored-by: Merkel Tranjes <[email protected]> Co-authored-by: Alexey Shekhirin <[email protected]> Co-authored-by: Federico Gimenez <[email protected]> Co-authored-by: stevencartavia <[email protected]> Co-authored-by: emmmm <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: MIHAO PARK <[email protected]> Co-authored-by: Tilak Madichetti <[email protected]> Co-authored-by: Emilia Hane <[email protected]> Co-authored-by: maradini77 <[email protected]> Co-authored-by: sashaodessa <[email protected]> Co-authored-by: Alvarez <[email protected]> Co-authored-by: MozirDmitriy <[email protected]> Co-authored-by: drhgencer <[email protected]> Co-authored-by: Matthias Seitz <[email protected]> Co-authored-by: anim001k <[email protected]> Co-authored-by: Julian Meyer <[email protected]> Co-authored-by: Karl Yu <[email protected]> Co-authored-by: Jennifer <[email protected]> Co-authored-by: Ivan Wang <[email protected]> Co-authored-by: GarmashAlex <[email protected]> Co-authored-by: Udoagwa Franklin <[email protected]> Co-authored-by: Luca Provini <[email protected]> Co-authored-by: Galoretka <[email protected]> Co-authored-by: sashass1315 <[email protected]> Co-authored-by: frisitano <[email protected]>

0xKarl98 requested review from Rjected, fgimenez, gakonst, mattsse, mediocregopher, rkrasiuk and yongkangc as code owners September 25, 2025 06:52

github-project-automation bot added this to Reth Tracker Sep 25, 2025

github-project-automation bot moved this to Backlog in Reth Tracker Sep 25, 2025

yongkangc requested a review from Copilot September 25, 2025 13:53

Copilot AI reviewed Sep 25, 2025

View reviewed changes

yongkangc requested changes Sep 26, 2025

View reviewed changes

github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Sep 26, 2025

0xKarl98 force-pushed the main branch from a88175e to 304dee2 Compare September 26, 2025 03:37

0xKarl98 requested a review from yongkangc September 26, 2025 13:01

yongkangc reviewed Sep 29, 2025

View reviewed changes

0xKarl98 requested a review from yongkangc September 29, 2025 12:30

yongkangc requested changes Oct 1, 2025

View reviewed changes

0xKarl98 requested a review from yongkangc October 1, 2025 08:47

jenpaff assigned yongkangc, shekhirin and Rjected Oct 6, 2025

Rjected previously requested changes Oct 6, 2025

View reviewed changes

0xKarl98 requested a review from Rjected October 7, 2025 11:00

yongkangc approved these changes Oct 8, 2025

View reviewed changes

mediocregopher approved these changes Oct 8, 2025

View reviewed changes

0xKarl98 added 5 commits October 13, 2025 12:07

fix: remove commits_history.txt file with typos

67c6f90

fix: resolve witness.rs syntax error and restore dependencies

1919e5b

Resolve errors

92da536

Resolve lint errors

3fc8290

Fix falure lint jobs

2472366

yongkangc reviewed Oct 13, 2025

View reviewed changes

git pull

ff5dfdd

trigger CI re-run

b8a97b6

Rjected previously requested changes Oct 13, 2025

View reviewed changes

0xKarl98 closed this Oct 13, 2025

github-project-automation bot moved this from In Progress to Done in Reth Tracker Oct 13, 2025

0xKarl98 reopened this Oct 13, 2025

github-project-automation bot moved this from Done to In Progress in Reth Tracker Oct 13, 2025

Remove unnecessary exclude_crates

cff4346

0xKarl98 requested a review from Rjected October 14, 2025 14:00

yongkangc approved these changes Oct 15, 2025

View reviewed changes

yongkangc enabled auto-merge October 15, 2025 03:39

yongkangc added this pull request to the merge queue Oct 15, 2025

Merged via the queue into paradigmxyz:main with commit 856ad08 Oct 15, 2025
41 of 42 checks passed

github-project-automation bot moved this from In Progress to Done in Reth Tracker Oct 15, 2025

jenpaff moved this from Done to Completed in Reth Tracker Oct 15, 2025

	fn save_diff<T: std::fmt::Debug>(&self, filename: &str, old: &T, new: &T) -> eyre::Result<PathBuf> {
	fn save_diff<T: std::fmt::Debug + PartialEq>(&self, filename: &str, old: &T, new: &T) -> eyre::Result<PathBuf> {

	fn save_json<T: serde::Serialize>(&self, filename: &str, data: &T) -> eyre::Result<PathBuf> {
	fn save_file<T: Serialize>(&self, filename: &str, data: &T) -> eyre::Result<PathBuf> {

refactor(engine): simplify InvalidBlockWitnessHook::on_invalid_block for better testability #18696

refactor(engine): simplify InvalidBlockWitnessHook::on_invalid_block for better testability #18696

Uh oh!

Conversation

0xKarl98 commented Sep 25, 2025 • edited by yongkangc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

yongkangc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yongkangc commented Sep 26, 2025

Uh oh!

0xKarl98 commented Sep 29, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xKarl98 Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xKarl98 commented Sep 29, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xKarl98 Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rjected left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yongkangc left a comment

Choose a reason for hiding this comment

Uh oh!

mediocregopher left a comment

0xKarl98 commented Sep 25, 2025 •

edited by yongkangc

Loading

0xKarl98 Sep 29, 2025 •

edited

Loading

0xKarl98 Oct 1, 2025 •

edited

Loading

0xKarl98 Oct 13, 2025 •

edited

Loading

0xKarl98 Oct 13, 2025 •

edited

Loading

0xKarl98 Oct 14, 2025 •

edited

Loading

0xKarl98 commented Oct 13, 2025 •

edited

Loading

0xKarl98 commented Oct 13, 2025 •

edited

Loading

0xKarl98 commented Oct 13, 2025 •

edited

Loading

0xKarl98 commented Oct 14, 2025 •

edited

Loading

0xKarl98 commented Oct 15, 2025 •

edited

Loading