fix: add bundle and transaction context to call_many errors #18127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazykissshout
requested review from
Rjected,
RomanHodulak and
mattsse
as code owners
mattsse
requested changes
Sep 3, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
this is indeed more helpful,
but this shouldnt be converted to an internal error, can we instead introduce a new error variant for this that wraps the error and adds a message as config?
Contributor
Author
|
@mattsse GM, Would please check the new change since last feedback? |
Contributor
Author
|
@mattsse Hi the 1.7.0 seems to be a long time ago.. maybe the CI block this for merge, All ci fixed now. |
klkvr
approved these changes
Oct 17, 2025
emhane
pushed a commit
to op-rs/op-reth
that referenced
this pull request
Oct 20, 2025
…xyz#18127) Co-authored-by: Matthias Seitz <[email protected]>
emhane
pushed a commit
to op-rs/op-reth
that referenced
this pull request
Oct 20, 2025
…xyz#18127) Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
eth_callManyfails during transaction preparation or execution, the error message doesn't indicate which specific bundle or transaction caused the failure. This makes debugging difficult when processing multiple bundles with multiple transactions each.Before:
insufficient funds for gas * price + valueAfter:
call execution error at bundle 1, tx 1: insufficient funds for gas * price + value