Added the setName function #250
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
undefined method PHPHtmlParser\Dom\HtmlNode::setName() |
mr-chetan
added a commit
to devanoxltd/php-html-parser
that referenced
this pull request
Aug 24, 2025
Introduces a setName method to the Tag class for setting the tag name and returning a cloned instance. Also adds a return type to the offsetGet method in Collection for improved type safety. paquettg#250
mr-chetan
added a commit
to devanoxltd/php-html-parser
that referenced
this pull request
Aug 24, 2025
Introduces a setName method to the Tag class for setting the tag name and returning a cloned instance. Also adds a return type to the offsetGet method in Collection for improved type safety. https: //github.com/paquettg/pull/250 Co-Authored-By: max cohen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed to change tag names during dom manipulations, so we added the setName function for this.