set find-links per resolve, not globally#23024
Draft
cburroughs wants to merge 1 commit intopantsbuild:mainfrom
Draft
set find-links per resolve, not globally#23024cburroughs wants to merge 1 commit intopantsbuild:mainfrom
cburroughs wants to merge 1 commit intopantsbuild:mainfrom
Conversation
As described at <pantsbuild#21223 (comment)>, if you set find-links (and that includes everyone with in-repo plugins by way of `pants.backend.plugin_development`) on one resolve, we were erroneously setting it for *all* resolves during lockfile generation. This materially impacts resolution time.
Contributor
Author
|
(Back to draft, found a complication.) |
Contributor
Author
|
Thanks for the contribution. We've just branched for 2.31.x, so merging this pull request now will come out in 2.32.x, please move the release notes updates to docs/notes/2.32.x.md if that's appropriate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described at
#21223 (comment), if you set find-links (and that includes everyone with in-repo plugins by way of
pants.backend.plugin_development) on one resolve, we were erroneously setting it for all resolves during lockfile generation. This materially impacts resolution time.