sqlfluff: Partition linter by templater#21937
Draft
grihabor wants to merge 26 commits intopantsbuild:mainfrom
Draft
sqlfluff: Partition linter by templater#21937grihabor wants to merge 26 commits intopantsbuild:mainfrom
grihabor wants to merge 26 commits intopantsbuild:mainfrom
Conversation
…sql/pants.backend.sql/g'
This reverts commit 1a7b8cb.
grihabor
added a commit
to grihabor/pants
that referenced
this pull request
Mar 17, 2025
Integration tests for sqlfluff are not true integration tests right now. They call LintRequest rules, but that skips the partitioning step. I need to test partitioning in pantsbuild#21937, so I had to rewrite the tests.
Contributor
|
(When this is ready: Thanks for the contribution. We've just branched for |
Contributor
|
Thanks for the contribution. We've just branched for 2.30.x, so merging this pull request now will come out in 2.31.x (but be backported as requested). Please move the release notes updates to docs/notes/2.31.x.md if that's appropriate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21936