Skip to content

Conversation

@dustinleblanc
Copy link

This could resolve #334

@rvtraveller
Copy link
Collaborator

I like this approach and am generally on board with the change. The one thing that I think would be useful is to print something out when the user has the GIT_SSH_COMMAND environment variable set. Something like "Using your custom GIT_SSH_COMMAND variable instead of the Build Tools default" or similar.

@sugaroverflow sugaroverflow modified the milestone: 2.0 Apr 15, 2020
@greg-1-anderson
Copy link
Member

I'd recommend that we instead get the user's GIT_SSH_COMMAND setting and then iterate through each of our custom entries:

  • -o UserKnownHostsFile=/dev/null
  • -o StrictHostKeyChecking=no
  • -o LogLevel=QUIET

We could make a map with entries like 'UserKnownHostsFile' => '/dev/null', and then composer the -o KEY=VALUE line if KEY does not already appear in the user's GIT_SSH_COMMAND.

That would be safer, and more likely to produce the desired result.

If GIT_SSH_COMMAND is not defined, we could just start with ssh and then run the same algorithm to add all of the config items.

@greg-1-anderson greg-1-anderson changed the base branch from master to main August 26, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow overrides to GIT_SSH_COMMAND

4 participants