Skip to content

Conversation

@kachick
Copy link
Collaborator

@kachick kachick commented Jun 20, 2023

Pull request for issue #{issue number}

Many dependabot PRs are failed from using old nodejs. See #827 as an example.

https://github.com/pankona/hashira/actions/runs/5258857960/jobs/9503647993#step:4:8

Run yarn install
yarn install v1.22.19
[1/[4](https://github.com/pankona/hashira/actions/runs/5258857960/jobs/9503647993#step:4:5)] Resolving packages...
[2/4] Fetching packages...
error [email protected]: The engine "node" is incompatible with this module. Expected version ">=1[6](https://github.com/pankona/hashira/actions/runs/5258857960/jobs/9503647993#step:4:7).13.0 || >=1[8](https://github.com/pankona/hashira/actions/runs/5258857960/jobs/9503647993#step:4:9).0.0". Got "14.21.3"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Updates

Looks like the maintainer is using asdf or rtx because this repository has a .tool-version file.
setup-node can parse it since v3

actions/setup-node#373
actions/setup-node@5b949b5

Using the same versions with CI should be better.

And we need to care microsoft/TypeScript#51567

@kachick kachick requested a review from pankona as a code owner June 20, 2023 10:20
@kachick kachick changed the title Use the same version of nodejs as specified in .tool-versions Fix WebApp CI with dependency issues Jun 20, 2023
@kachick
Copy link
Collaborator Author

kachick commented Jun 20, 2023

All CI passed 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant