digiline NIC crash

[OgelGames]

2020-09-14 13:09:53: ERROR[CurlFetch]: https://subgames.minetest.land/g.php?pw=  not found (HTTP response code said error) (response code 400)
2020-09-14 13:10:54: ERROR[CurlFetch]: https://subgames.minetest.land/g.php?pw=  not found (HTTP response code said error) (response code 400)
2020-09-14 13:11:42: ERROR[CurlFetch]: https://subgames.minetest.land/g.php?pw=( ) not found (HTTP response code said error) (response code 400)
2020-09-14 13:11:54: ERROR[CurlFetch]: https://subgames.minetest.land/g.php?pw=  not found (HTTP response code said error) (response code 400)

2020-09-14 13:14:19: ERROR[CurlFetch]: https://subgames.minetest.land/g.php?pw=  not found (HTTP response code said error) (response code 400)
2020-09-14 13:15:05: ERROR[CurlFetch]: https://subgames.minetest.land/g.php?pw=( ) not found (HTTP response code said error) (response code 400)
2020-09-14 13:15:07: ERROR[CurlFetch]: https://subgames.minetest.land/g.php?pw=( ) not found (HTTP response code said error) (response code 400)
2020-09-14 13:15:19: ERROR[CurlFetch]: https://subgames.minetest.land/g.php?pw=  not found (HTTP response code said error) (response code 400)
2020-09-14 13:15:38: ERROR[CurlFetch]: https://subgames.minetest.land/s.php?pw=( )&i=spider$0$0$0 not found (HTTP response code said error) (response code 400)
2020-09-14 13:16:19: ERROR[CurlFetch]: https://subgames.minetest.land/g.php?pw=  not found (HTTP response code said error) (response code 400)
2020-09-14 13:17:06: ERROR[CurlFetch]: https://subgames.minetest.land/g.php?pw=( ) not found (HTTP response code said error) (response code 400)
2020-09-14 13:17:19: ERROR[CurlFetch]: https://subgames.minetest.land/g.php?pw=  not found (HTTP response code said error) (response code 400)
2020-09-14 13:17:25: ERROR[CurlFetch]: https://subgames.minetest.land/g.php?pw=( ) not found (HTTP response code said error) (response code 400)
2020-09-14 13:17:34: ERROR[CurlFetch]: https://subgames.minetest.land/r.php?pw=( )&i=spider not found (HTTP response code said error) (response code 400)
2020-09-14 13:17:37: ERROR[CurlFetch]: https://subgames.minetest.land/g.php?pw=( ) not found (HTTP response code said error) (response code 400)

EDIT: found what was causing it, it was this code in a Lua controller connected to an NIC: (there is actually a lot more, but this is the bit that is causing the crashes:

function write(name, pos)
 digiline_send("nic", "https://subgames.minetest.land/s.php?pw="..mem.pw.."&i="..name.."$"..pos.x.."$"..pos.y.."$"..pos.z)
end
function load()
 digiline_send("nic", "https://subgames.minetest.land/g.php?pw="..mem.pw)
end
function delete(name)
 digiline_send("nic", "https://subgames.minetest.land/r.php?pw="..mem.pw.."&i="..name)
end

[BuckarooBanzay]

interesting, the request itself should not crash the server.. 🤔
@Lejo1 this looks like your code 😄 any ideas?

[Lejo1]

Hmm,

this Lua controller saves and reads data to my Webserver. I have multiple of them so they will sync automatically the coordinates for the jumpdrives but it never caused a crash and I also wasn't online the last time.

Were there any changes to the mod or maybe to the minetest release?

[BuckarooBanzay]

Were there any changes to the mod or maybe to the minetest release?

Not that i'm aware of 🤷 there might be more details in the log files, i'll check them later today, thanks for the reply 👍

[BuckarooBanzay]

disabled the NIC until i can replicate/solve that issue, i hope nothing breaks because of the unknown node 😓

[S-S-X]

disabled the NIC until i can replicate/solve that issue, i hope nothing breaks because of the unknown node

Could also just override NIC functionality with noop() via pandorabox customizations to keep nodes in world but functionality disabled.
I mean like this:

minetest.override_item("digistuff:nic",{ digiline = { receptor = {}, effector = {} } })

[BuckarooBanzay]

I was in a hurry, commenting out from secure.http_mods seemed like the obvious choice at the time...
Anyways: i applied your changes here: pandorabox-io/pandorabox_custom@6aa53d8

EDIT: there were no additional infos in the debug logs, i have no idea how to reproduce this

[S-S-X]

sorry for that.. misclicked..

Actually I was thinking could this be just bad luck and server just caused segfault for whatever another reason and nic errors just happened to be there just before it... of course very hard to say for sure without any backtrace.

[BuckarooBanzay]

sorry for that.. misclicked..

Actually I was thinking could this be just bad luck and server just caused segfault for whatever another reason and nic errors just happened to be there just before it... of course very hard to say for sure without any backtrace.

I thought that too at first but there were no segfaults 😕

[OgelGames]

So I did some testing with the code I copied, and I was able to recreate the error, but it didn't crash, I just got the errors in chat 😕

I have the full code if you want it (all 251 lines of it), but this is all I needed to produce the errors: (note the single space after pw=)

digiline_send("nic", "https://subgames.minetest.land/r.php?pw= ")

It seems that the cause of the problem is that the NIC doesn't filter spaces, and just leaves them as is when sending the request, because any text after pw= that doesn't contain spaces works as intended.

It still doesn't explain why it crashed though, I might try it on the test server to see if it crashes there...

EDIT: no crashes on test server 😕