CLN: Remove unused private attributes in stata module#57818
Merged
mroeschke merged 1 commit intopandas-dev:mainfrom Mar 12, 2024
Merged
CLN: Remove unused private attributes in stata module#57818mroeschke merged 1 commit intopandas-dev:mainfrom
mroeschke merged 1 commit intopandas-dev:mainfrom
Conversation
tqa236
force-pushed
the
remove-private-variable
branch
from
9b16c59 to
adb1115
Compare
datapythonista
changed the title
datapythonista
approved these changes
Mar 12, 2024
Member
datapythonista
left a comment
datapythonista
left a comment
There was a problem hiding this comment.
lgtm, thanks for the clean up @tqa236
mroeschke
approved these changes
Mar 12, 2024
Member
|
Thanks @tqa236 |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
Remove unused private code in stata module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to #49228, all of the internal state of the reader object is now
_private, so I try to remove the unused one detected byvulture