TYP: Index.join, get_indexer, reindex#40390
Closed
jbrockmendel wants to merge 6 commits intopandas-dev:masterfrom
Closed
TYP: Index.join, get_indexer, reindex#40390jbrockmendel wants to merge 6 commits intopandas-dev:masterfrom
jbrockmendel wants to merge 6 commits intopandas-dev:masterfrom
Conversation
Member
will need to use comments to retain this info for now because I'll start another branch shortly, in the same vien as #36092 checking against numpy master to get visibility of upcoming changes |
Member
Author
|
OK, I guess I'll mothball this to clear the queue, will re-open when these are supported |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@simonjayhawkins this is technically incorrect bc im specifying returned dtypes as np.intp. Is there a valid way to do this? In working in core.internals trying to figure out whether we want int64 or intp I had to track all of these down to be sure. Would prefer to avoid re-doing this in a few weeks when I forget.