Closed
Conversation
simonjayhawkins
added
CI
Member
|
Neat, LGTM pending green |
Member
Author
|
both #37898 and #37872 we independently Green. The only downside here is that Index is part of the public API, so using Generic here means that the backing array becomes part of the public type interface and we may want to hide this as an implementation detail. I think that I'll open another PR that justs ignores the error for now while we give this more thought. |
Member
Author
|
I'll close this, while we still have np.ndarray resolving to Any which masks errors, since it's not just Index._values but also getitem still needs to be overloaded for the slice and use a typevar as a followon to #37898, so should do that first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @jbrockmendel