ENH: storage_options for to_excel#37818
Merged
jreback merged 1 commit intopandas-dev:masterfrom Nov 14, 2020
twoertwein:master
Merged
ENH: storage_options for to_excel#37818jreback merged 1 commit intopandas-dev:masterfrom twoertwein:master
jreback merged 1 commit intopandas-dev:masterfrom
twoertwein:master
Conversation
Contributor
|
thanks @twoertwein |
Member
Author
|
is there a way to re-use documentation? We have blocks about compression storage_options in many places. It would be cool to have them in one place and then import them. |
Contributor
yes for sure, we have the _shared_docs infrastructure, but for excel its prob enough just to use the Appenders |
This was referenced Nov 14, 2020
Member
|
Think this broke CI - https://github.com/pandas-dev/pandas/pull/37818/checks?check_run_id=1399068710 - opening up a fix |
Member
Author
|
oh yes! I think a pytest.importorskip should fix this. @alimcmaster1 Are you already making a PR? edit: just saw your PR :) Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff