TYP: misc fixes for numpy types 4#36102
Closed
simonjayhawkins wants to merge 4 commits intopandas-dev:masterfrom
Closed
TYP: misc fixes for numpy types 4#36102simonjayhawkins wants to merge 4 commits intopandas-dev:masterfrom
simonjayhawkins wants to merge 4 commits intopandas-dev:masterfrom
Conversation
Member
simonjayhawkins
commented
Sep 3, 2020
simonjayhawkins
commented
jbrockmendel
reviewed
Sep 4, 2020
WillAyd
reviewed
Sep 9, 2020
| _ndarray: np.ndarray | ||
| @property | ||
| def _ndarray(self) -> np.ndarray: | ||
| raise AbstractMethodError(self) |
Member
There was a problem hiding this comment.
Any reason to not prefer an abc here?
|
|
||
| @overload | ||
| def to_datetime( | ||
| # error: Overloaded function signatures 1 and 3 overlap with incompatible return types |
Member
There was a problem hiding this comment.
Hmm do you know why we are getting this error? Seems like an issue with the annotation
Member
Author
There was a problem hiding this comment.
since np.ndarray resolves to Any, this will need ignores if merging now b4 the numpy types are available. will close and include in #36092 instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.