Set process exit code when sync fails#119
Merged
k3d3 merged 1 commit intopanamax-rs:masterfrom Jun 6, 2024
Merged
Conversation
k3d3
approved these changes
Jun 6, 2024
Member
k3d3
left a comment
k3d3
left a comment
There was a problem hiding this comment.
LGTM - thank you, and sorry for taking so long to get to this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If using panamax in a script, this is useful to catch problems.
This commit will catch the most eggregious problems like configuration problems, but download failures in
panamax syncwill still exit successfully. I'll need to look into making more changes to allow catching this.