Raise error when registering duplicate routes#3086
Closed
Cyber-Vansh wants to merge 2 commits intopallets:mainfrom
Closed
Raise error when registering duplicate routes#3086Cyber-Vansh wants to merge 2 commits intopallets:mainfrom
Cyber-Vansh wants to merge 2 commits intopallets:mainfrom
Conversation
Member
|
What was the reason for opening another PR, considering there is already one (#3038)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Registering the same route multiple times currently fails silently. Werkzeug
continues using the first registered rule, which can lead to subtle bugs.
This change raises a
ValueErrorwhen a duplicate route is registered.Changes
Map.addMotivation
This makes routing errors visible early and aligns route handling with endpoint
duplication checks.
Fixes #3037