Type annotations: I think `werkzeug.wrappers.Request.json` can never be None

[oprypin]

I am talking about this property: https://werkzeug.palletsprojects.com/en/stable/wrappers/#werkzeug.wrappers.Request.json

werkzeug/src/werkzeug/wrappers/request.py

Lines 544 to 545 in 504a8c4

	@property
	def json(self) -> t.Any | None:

I think it can never actually return None, because it calls get_json() with all defaults, which is silent=False, making it never return None and raise in those cases instead.

This issue is still current in the latest release and latest unreleased code.

I am using Pyright, and it complains about usages such as flask.request.json["foo"].

[ThiefMaster]

w/o checking the code: What if the request payload is literally null which, when parsed as json, becomes None?

[oprypin]

@ThiefMaster Uhh yes, that's technically true.
However, the intentions of the type annotations around here are clearly the following:

• Any means "any JSON type" (without special-casing null)
• Any | None means the same, OR that it was not provided.

You can see this logic applied in the definitions of get_json() right below.

[oprypin]

Or from the pragmatic perspective:

The code some_json["foo"] has many reasons to fail, and the situation where it's null should get equal treatment to the situation where it's a list instead.
Preventing only the None case is not meaningful when the other case can still be let through.